Bug 209073 - NewBugzillaTaskEditor contains not all attributes from enter_bug.cgi
Summary: NewBugzillaTaskEditor contains not all attributes from enter_bug.cgi
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 2.1   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 2.2   Edit
Assignee: Frank Becker CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks:
 
Reported: 2007-11-07 14:13 EST by Frank Becker CLA
Modified: 2007-11-19 15:47 EST (History)
3 users (show)

See Also:


Attachments
patch (16.92 KB, patch)
2007-11-07 17:15 EST, Frank Becker CLA
no flags Details | Diff
mylyn/context/zip (6.81 KB, application/octet-stream)
2007-11-07 17:15 EST, Frank Becker CLA
no flags Details
new patch (12.02 KB, patch)
2007-11-14 23:45 EST, Frank Becker CLA
no flags Details | Diff
mylyn/context/zip (9.39 KB, application/octet-stream)
2007-11-14 23:45 EST, Frank Becker CLA
no flags Details
correted Patch (11.57 KB, patch)
2007-11-18 11:25 EST, Frank Becker CLA
no flags Details | Diff
mylyn/context/zip (3.19 KB, application/octet-stream)
2007-11-18 11:25 EST, Frank Becker CLA
no flags Details
mylyn/context/zip (5.74 KB, application/octet-stream)
2007-11-19 15:47 EST, Steffen Pingel CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Frank Becker CLA 2007-11-07 14:13:10 EST
for all Bugzialla Versions supported by Mylyn the following attributes are not included in NewBugzillaTaskEditor
 - Depends on: 
 - Blocks: 
 - Cc:
 
 since Version 3.0 the attribute Attachment: is supported
Comment 1 Frank Becker CLA 2007-11-07 14:24:00 EST
I look at this.

By the way 

	static final String TEST_BUGZILLA_216_URL = "http://mylyn.eclipse.org/bugs216";
	
in IBugzillaConstants.java is not used. (returns not found) and not used in any tests.
Comment 2 Frank Becker CLA 2007-11-07 17:15:26 EST
Created attachment 82379 [details]
patch

Please veryfy if this is Ok and do not break some API
Comment 3 Frank Becker CLA 2007-11-07 17:15:31 EST
Created attachment 82380 [details]
mylyn/context/zip
Comment 4 Robert Elves CLA 2007-11-14 16:57:45 EST
Looks good Frank. Lets pull out the attachment related code and work on that under bug#209870 as this has potential to get involved.  I tested the new fields on the new bug editor and it all worked fine here.  The content assist in the search and new bug editor fields didn't appear to work. Other than these nits it is looking good.  When you have a revised patch, append [patch] to the bug summary.

Reassigning to you Frank...
Comment 5 Frank Becker CLA 2007-11-14 23:45:27 EST
Created attachment 82936 [details]
new patch

points from comment 4 are included.

The content assist in the search  bug editor is removed.

Must look what do do to get this work.
Comment 6 Frank Becker CLA 2007-11-14 23:45:29 EST
Created attachment 82937 [details]
mylyn/context/zip
Comment 7 Frank Becker CLA 2007-11-15 13:46:03 EST
By error I include the Patch for  bug 209250 with this patch.
Comment 8 Robert Elves CLA 2007-11-17 16:12:09 EST
Frank, for IP reasons and to keep discussion related to additional changes that will be needed to the action section of the bug editor, could you split this up and put the assigned to / content assist on bug#209250. Thanks!
Comment 9 Frank Becker CLA 2007-11-18 11:25:44 EST
Created attachment 83187 [details]
correted Patch

worke done from comment #8
Comment 10 Frank Becker CLA 2007-11-18 11:25:46 EST
Created attachment 83188 [details]
mylyn/context/zip
Comment 11 Robert Elves CLA 2007-11-18 14:32:27 EST
Great. Patch applied, ip log updated. 
* Add self to cc doesn't work for new bugs so removed the check field
* Add CC field wasn't working, required modifications to BugzillaClient to swap out he NewCC for CC attribute id/values (oddity of bugzilla)
* Content assist enabled for CC field in New Bug editor updated

Flagged for new and noteworthy.

Steffen, I noticed that this causes the Assigned to field of the Trac editor to be editable. Could you update the read only flag on that attribute in trac?
Comment 12 Steffen Pingel CLA 2007-11-19 15:47:31 EST
Done.
Comment 13 Steffen Pingel CLA 2007-11-19 15:47:36 EST
Created attachment 83279 [details]
mylyn/context/zip