Bug 209034 - [Viewers] Provide cell editor that supports native drop-down list behavior
Summary: [Viewers] Provide cell editor that supports native drop-down list behavior
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-07 09:58 EST by Bob Fraser CLA
Modified: 2019-09-06 16:06 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bob Fraser CLA 2007-11-07 09:58:10 EST
On the Modify Faceted Project window, there is a usability problem associated with errors.  If I change the Version of a project facet and click finish, I can get an error message that another facet must be changed.  If I correct the other facet setting, the error message remains and the Finish button is greyed out.  I must click somewhere in the white space of the window for the error message to go away.
Comment 1 Konstantin Komissarchik CLA 2007-11-07 10:07:03 EST
This is a limitation of SWT. The combo list cell editor doesn't support true drop-down list behavior. Even if you configure it to be read-only, upon selection of an item in the list, the focus remains on the cell editor and the change is not actually propagated until the user changes focus manually.

Turning this into an enhancement request for SWT.
Comment 2 Boris Bokowski CLA 2008-01-24 10:16:10 EST
Would you be able to provide a simple snippet demonstrating the problem?
Comment 3 Thomas Schindl CLA 2008-01-24 10:22:57 EST
Boris I think the problem is that we are calling applyEditorValue() only if the cell looses focus and not when the selection changes.

What Bob is requesting is an intermediate applyEditorValue() without quiting the editor but simply syncing back the value to the model-object. 

Could this make sense as a generic feature, when we would provide such a possibility people one could e.g. update the value from a TextCellEditor on SWT.Modify ;-)
Comment 4 Konstantin Komissarchik CLA 2008-01-25 11:52:44 EST
It's a little more complicated than that. Consider these two cases:

1. Opening the combo and using the mouse to select a value. The expected behavior in this case is that the value is applied immediately.

2. Opening the combo and using the keyboard to navigate the list and eventually selecting the item using the enter key. In this case, the expected behavior is that the value is applied upon pressing the enter key.

In both of these case, currently, the cell editor remains active until user clicks elsewhere. Then the value is applied.

I have actually been playing around with improving this behavior in a context of another bug. I ended up cloning and modifying CCombo and ComboBoxCellEditor in order to achive immediate de-activation upon selection in the above two cases as well as a related usability improvement of having the combo box start in an open state upon activation (one less click for the user). 

I am planning on turning my work into patches. I will attach them here.
Comment 5 Boris Bokowski CLA 2008-01-25 13:01:24 EST
Patches would be great. Do you think you can have them ready before the IP review deadline for Ganymede?
Comment 6 Konstantin Komissarchik CLA 2008-01-25 13:15:47 EST
Could you remind me when the IP review deadline for Ganymede is? Also, do you happen to know if IP review still needs to happen if I anm Eclipse committer already (WTP) and have signed all of the committer paperwork, etc.
Comment 7 Boris Bokowski CLA 2008-01-25 13:42:12 EST
The deadline is January 31st. For the rules, refer to http://www.eclipse.org/legal/EclipseLegalProcessPoster.pdf

Since you don't work for the same member company, it has to go through IP review if it has more than 250 lines of code.

If your employer agreed that you are allowed to contribute to any Eclipse project (rather than only specific ones), this would reduce the number of steps in the review process.
Comment 8 Konstantin Komissarchik CLA 2008-01-25 13:51:31 EST
Thanks for the info. I will work on creating a patch next week. Should be less than 250 lines in any event.
Comment 9 Boris Bokowski CLA 2009-11-26 09:55:04 EST
Hitesh is now responsible for watching bugs in the [Viewers] component area.
Comment 10 Eclipse Webmaster CLA 2019-09-06 16:06:40 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.