Bug 208602 - [Dialogs] Open Type dialog needs accessible labels
Summary: [Dialogs] Open Type dialog needs accessible labels
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.5 M7   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility, helpwanted, polish
Depends on:
Blocks:
 
Reported: 2007-11-02 14:22 EDT by Christine Rice CLA
Modified: 2009-06-03 13:38 EDT (History)
6 users (show)

See Also:

Attachments
Patch for bug 208602 (3.60 KB, text/plain)
2007-12-03 06:25 EST, Peter Friese CLA 		bokowski: iplog+
Details
mylyn/context/zip (1.13 KB, application/octet-stream)
2007-12-03 06:25 EST, Peter Friese CLA 		no flags Details
Fix2 (3.04 KB, patch)
2008-12-05 07:00 EST, Markus Keller CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christine Rice CLA 2007-11-02 14:22:10 EDT 
Build ID: 3.3.1

Steps To Reproduce:
The open type dialog (JavaUI.createTypeDialog) has an input text field for a user to enter the desired class, and a list of matching results. Neither of these have accessible labels according to Microsoft Inspect Objects (Inspect shows the Name of both of these fields as "none").



More information:
Comment 1 Martin Aeschlimann CLA 2007-11-19 06:33:16 EST 
We're using the FilteredItemsSelectionDialog from platform.ui.
Comment 2 Peter Friese CLA 2007-12-03 05:49:12 EST 
I had a look into this. The problem is that the layout of the dialog doesn't allow for accessible input fields:

[Enter type name...] [menu]
[Text input]
[Matching items:] [Progress label]
[List box]

As far as I know, the accessible name of an input field is derived by taking the nearest other control that is located to the left of the control. If you have a look at the layout depicted above, you can see that the nearest label for the text input is the dropdown menu, whereas for the listbox, it is the progress label.

I fear that in order to resolve this bug, we need to change the layout of the dialog quite a bit: The menu and the progress label would need to be placed at a different location. Not sure if that's intended.
Comment 3 Markus Keller CLA 2007-12-03 06:02:08 EST 
You have to add AccessibleAdapters to the input field and the table, see e.g.
org.eclipse.jdt.internal.ui.dialogs.TypeSelectionComponent.createContent(String, int).
Comment 4 Peter Friese CLA 2007-12-03 06:25:36 EST 
Created attachment 84303 [details]
Patch for bug 208602

Patch adds accessible names for listbox and text entrz field.
Comment 5 Peter Friese CLA 2007-12-03 06:25:41 EST 
Created attachment 84304 [details]
mylyn/context/zip
Comment 6 Tod Creasey CLA 2007-12-03 16:28:30 EST 
Patch with minor changes released for build >20071204
Comment 7 Tod Creasey CLA 2007-12-11 13:17:04 EST 
Reopening - the fix is overiding the text in the list entry
Comment 8 Zina Mostafia CLA 2008-10-27 14:27:47 EDT 
Can you please add a target Milestone when a fix will be provided ?
Comment 9 Markus Keller CLA 2008-12-05 07:00:52 EST 
Created attachment 119610 [details]
Fix2

> Reopening - the fix is overiding the text in the list entry
Patch fixes this problem.
Comment 10 Dani Megert CLA 2009-04-15 04:41:15 EDT 
Fixed in HEAD.
Available in builds > N20090414-2000.
Comment 11 Dani Megert CLA 2009-04-29 06:11:52 EDT 
Verified in I20090429-0100.