Bug 208332 - [DataBinding] Accept element types in Observables factory methods
Summary: [DataBinding] Accept element types in Observables factory methods
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3.1   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.4 M4   Edit
Assignee: Matthew Hall CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-10-31 18:13 EDT by Matthew Hall CLA
Modified: 2008-03-28 16:45 EDT (History)
0 users

See Also:


Attachments
Support element type parameter in Observable observable collection factory methods (26.33 KB, patch)
2007-10-31 18:13 EDT, Matthew Hall CLA
no flags Details | Diff
Accept element types in Observables factory methods (33.43 KB, patch)
2007-12-06 02:58 EST, Matthew Hall CLA
no flags Details | Diff
Updated patch with more tests (39.17 KB, patch)
2008-01-29 13:40 EST, Matthew Hall CLA
no flags Details | Diff
mylyn/context/zip (3.79 KB, application/octet-stream)
2008-01-29 13:40 EST, Matthew Hall CLA
no flags Details
Final patch with all tests (78.55 KB, patch)
2008-02-13 14:33 EST, Matthew Hall CLA
no flags Details | Diff
mylyn/context/zip (20.78 KB, application/octet-stream)
2008-02-13 14:33 EST, Matthew Hall CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Hall CLA 2007-10-31 18:13:05 EDT
Created attachment 81794 [details]
Support element type parameter in Observable observable collection factory methods

Observables has methods for creating sets and lists which are empty, static, unmodifiable, or proxies.  None of these methods accept an elementType parameter, which forces me to weaken contracts on my master-detail collections.  The attached patch:
* Complements the existing factory methods with new methods accepting an elementType parameter.
* Adds unmatched methods (e.g. there is a proxyObservableSet method but no proxyObservableList)
* Adds methods for converting an IObservableValue to an IObservableList or IObservableSet.  This item is unrelated to the others but I've found it useful and so include it here.  It's quite useful as a viewer input in conjunction with an Observable(List|Set)(Tree)?ContentProvider.  If necessary I can file a separate bug for this item and revise the patch.
Comment 1 Matthew Hall CLA 2007-11-29 11:49:08 EST
Ping.  All of these features are distinct and separable.  I can separate this RFE into multiple smaller ones (one for each bullet point in comment #0) if that makes the IP process easier.  
Comment 2 Matthew Hall CLA 2007-12-05 23:09:16 EST
Reminder to self: resubmit patch with default Eclipse formatting, and add contribution and copyright comments
Comment 3 Matthew Hall CLA 2007-12-06 02:58:23 EST
Created attachment 84601 [details]
Accept element types in Observables factory methods

Overhauled javadocs in Observables, added contributor comments.
Comment 4 Matthew Hall CLA 2007-12-06 03:03:19 EST
Complete, ready for review.
Comment 5 Matthew Hall CLA 2008-01-21 17:46:13 EST
Taking ownership
Comment 6 Matthew Hall CLA 2008-01-23 17:22:58 EST
Reminder: Add ProxyObservableListTest which was accidentally included in 208858 patch instead of this bug.
Comment 7 Matthew Hall CLA 2008-01-29 13:40:07 EST
Created attachment 88171 [details]
Updated patch with more tests

Still need tests for:
* EmptyObservableList
* EmptyObservableSet
* UnmodifiableObservableSet
Comment 8 Matthew Hall CLA 2008-01-29 13:40:09 EST
Created attachment 88172 [details]
mylyn/context/zip
Comment 9 Matthew Hall CLA 2008-02-13 14:33:26 EST
Created attachment 89673 [details]
Final patch with all tests
Comment 10 Matthew Hall CLA 2008-02-13 14:33:28 EST
Created attachment 89674 [details]
mylyn/context/zip
Comment 11 Matthew Hall CLA 2008-02-13 14:58:50 EST
Released to HEAD > 20080213
Comment 12 Matthew Hall CLA 2008-03-28 16:45:55 EDT
Verified by code inspection in 3.4M5