Bug 207290 - Resource is included in the API but not used anywhere
Summary: Resource is included in the API but not used anywhere
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: ERCP (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: ercp.eswt CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2007-10-24 08:11 EDT by Jussi Suistomaa CLA
Modified: 2021-07-15 12:17 EDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jussi Suistomaa CLA 2007-10-24 08:11:29 EDT 
Resource class from SWT is included in eSWT API spec (Javadoc) but is not used anywhere. Either Resource should be removed from the spec or graphics resources (Color, GC, Image, Font) should be changed to derive from Resource like in SWT. 

Maybe it would be best to take Resource into use, rather than removing it, for better compatibility with SWT code?
Comment 1 Mark Rogalski CLA 2007-10-25 08:19:52 EDT 
The Resource class is for eRCP applications to use to help manage resources. eSWT can not have a dependency on anything in jFace since eSWT must be able to run stand-alone. So I don;t think there is anything that should be changed here.
Comment 2 Jussi Suistomaa CLA 2007-10-25 09:03:08 EDT 
I mean the org.eclipse.swt.graphics.Resource class that is included in eSWT API. 

If you take a look at the eSWT Javadoc there is org.eclipse.swt.graphics.Resource included in the API. It is inluded in eSWT API itself but not used by eSWT. One would assume that graphics resources would be deriving from it but they are not. 

Maybe you are thinking about some other Resource but this is about org.eclipse.swt.graphics.Resource that is in eSWT API.
Comment 3 Uriel Liu CLA 2008-07-31 03:02:45 EDT 
I'll remove Resource from eSWT API spec in 1.2.
Comment 4 Gorkem Ercan CLA 2008-07-31 10:48:12 EDT 
Isn't this going to break the compatability with the SWT? Resource is available on SWT and all the graphics resources derive from it.
Comment 5 Mark Rogalski CLA 2008-07-31 11:05:12 EDT 
None of the eSWT implementations rely on it, so big SWT relying on it doesn't really matter. But, is this class usable by applications? If so we should probably not remove it. How much footprint would be saved by removing it? Is it even significant?
Comment 6 Uriel Liu CLA 2008-08-03 22:17:04 EDT 
It's not included in our runtime packages but only included in the JavaDoc, the reason to remove it from JavaDoc is to aviod confusion. Or, to include this in our runtime for consistency.
Comment 7 Mark Rogalski CLA 2008-08-04 10:46:24 EDT 
Ah. So removing API from JavaDoc is the correct action. Thanks