Description Tomer Mahlin 2007-10-17 05:43:17 EDT

Steps To Reproduce:
---------------------
This is a Bidi specific defect. Please use Bidi characters instead of capital Latin letters in the text samples below.

1. Create module with Bidi name (e.g. MY_MODULE)
2. Create nested directory with Bidi subfolders (e.g. ABC\DEF\_123\Aa)
3. Create several artifacts in this directory (e.g. MY_BO, MY_INTERFACE etc.)
4. Make sure you apply some changes to the artifacts and don't save them.
5. Select File->Exit
6. Observe how artifacts paths appear in Save Resources dialog

The expected layout is:
<artifact name> [<full artifact file path>]

Actual display:
  ELUDOM_YM] TCEJBO_YM\CBA\FED\_123\Aa\TCEJBO_YM.xsd]

Expected display:
  TCEJBO_YM [ELUDOM_YM\CBA\FED\_123\Aa\TCEJBO_YM.xsd]

Additional info: 
-----------------
 To resolve the issue TextProcessor should be used. Please see more technical details at this site:
http://wiki.eclipse.org/index.php/New_Bidi_APIs
 It seems that TextProcessor is applied in this scenario since artifact path is correctly displayed. However, the overall display of the whole expression is still incorrect. It seems that square brackets (']' and '[') are not considered as part of separators list when TextProcessor is applied. The expected call for TextProcessor should look like this:
    String myExpression = "ARTIFACT_NAME [ARTIFACT_PATH]";    
    myExpression = TextProcessor.process(myExpression, "/\:.][");


More information:
-------------------
Grant Taylor debugged the problem, and this code is the culprit:

    /* (non-Javadoc)
     * @see org.eclipse.jface.viewers.ILabelProvider
     */
    public final String getText(Object element) {
        if (element instanceof IWorkbenchPart) {
            IWorkbenchPart part = (IWorkbenchPart) element;
            String path = part.getTitleToolTip();
            if (path == null || path.trim().length() == 0) {
                return part.getTitle();
            }
            return part.getTitle() + "  [" + path + "]"; //$NON-NLS-1$ //$NON-NLS-2$
        }
        if (element instanceof Saveable) {
        	Saveable model = (Saveable) element;
            String path = model.getToolTipText();
            if (path == null || path.trim().length() == 0) {
                return model.getName();
            }
            return model.getName() + "  [" + path + "]";  //$NON-NLS-1$ //$NON-NLS-2$
        	
        }
        return null;
    }

The above is taken from the org.eclipse.ui.model.WorkbenchPartLabelProvider class.