Bug 204863 - [Patch] Create Patch action does not work for selected Change Set with incoming changes
Summary: [Patch] Create Patch action does not work for selected Change Set with incomi...
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: platform-cvs-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-27 16:27 EDT by Gerry Kessler CLA
Modified: 2019-09-06 16:03 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Gerry Kessler CLA 2007-09-27 16:27:29 EDT
With a change set selected in the sync view, the 'Create Patch...' action is available from the context menu.   However, rather than producing the expected patch, it produces a dialog stating: "There were no changes found to be included in the patch."

I hope that the fix won't be to simply hide the context menu since this would be a very useful feature to have.

Found using Eclipse 3.4M2 Build id: I20070921-0919
Comment 1 Szymon Brandys CLA 2007-10-01 04:26:24 EDT
I can't reproduce the issue. Could you provide more detailed steps? The only explanation that comes to my mind is that those changes from your workspace are already in the repository.
Comment 2 Gerry Kessler CLA 2007-10-01 11:05:43 EDT
Quite true.  The changes are in the repository.  However, the workspace I was currently in did not have those changes.   I can tell this because the synch view tells me so.

What I was hoping for was a dialog that would produce a patch from the differences.  All the information to produce a patch from those differences is available.   

From a UI perspective, it may be trickier.  What if the unsynched workspace had some, but not all, of the changes?   Does one expect a patch for the current difference, or does one expect a patch that produced the change set?   Ideally there would be an option of some kind, but I am not sure there is any metadata with the change set that specifies what produced it.
Comment 3 Tomasz Zarna CLA 2007-10-08 09:45:12 EDT
Gerry, I'm trying to figure out what you request is about. Firstly, I was thinking that you would like to be able to create a patch basing only on current (even out-dated) synchronization. This could be quite difficult if not impossible to achieve as it seems that all "create patch" actions are all based on the same diff operation. When triggered the action is actually only interested in resources under selection not in their sync state. I'm not sure if I make myself clear enough, moreover these are just my assumptions.

On second thoughts, I realized that maybe you're talking about creating a patch basing on incoming changes. Is it closer to your intention? Well, the sync view does look like having all required information, but still it can be "tricky".

Please comment and give us some more details.
Comment 4 Gerry Kessler CLA 2007-10-08 13:15:42 EDT
When a local file is not synced and updated with it's branch, it seems reasonable to me that "Create Patch..." would allow a reverse patch to be created where the created patch file would be a file of the differences that would be injected into the CVS version to get it to the same state as the local file.  

When the sync view is in ChangeSet mode, I think the semantics get a lot fuzzier.  Would the expectation of "Create Patch..." be to produce a (reverse) patch from the current differences, or to produce a patch that was used to create the Change Set in the beginning?   I have used Perforce in the past, and at first I thought the Change Set was more higly correlated with the Perforce Change List.  Whereas the Change List has/is the metadata to say what files, versions, differences etc. were used to create the checkin, I am doubtful that CVS has the same capability.

I'm sorry if I am not being very clear, and I think that this is much more of an enhancement request than a bug.  Unfortunately, I cannot come up with a very good use case for this functionality either, and you are welcome to mark will not fix, if you wish.
Comment 5 Tomasz Zarna CLA 2008-10-20 07:11:00 EDT
I believe this is a valid request, the problem is that, afaik cvs diff command shows the difference between two revisions of a file but only for outgoing changes. The command gives you no valuable result if a file has only incoming changes. So to address this request we cannot simply use current DiffOperation implementation. Patches will be accepted.
Comment 6 Eclipse Webmaster CLA 2019-09-06 16:03:40 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.