Bug 204744 - [ssh][encodings] Command view input does not honor specified encoding
Summary: [ssh][encodings] Command view input does not honor specified encoding
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 2.0.1   Edit
Assignee: Martin Oberhuber CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 191599
  Show dependency tree
 
Reported: 2007-09-26 19:01 EDT by Martin Oberhuber CLA
Modified: 2007-09-27 01:09 EDT (History)
1 user (show)

See Also:
xuanchen: review+

Attachments
Patch fixing the issue (3.03 KB, patch)
2007-09-26 19:04 EDT, Martin Oberhuber CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2007-09-26 19:01:43 EDT 
While the RSE Command View ("Launch Shell") supports the encoding specified in the host properties for its output, it does not support it for commands entered.

e.g., on a connection specified as "UTF-8", do

ls ağb

does not perform the proper command.

-----------Enter bugs above this line-----------
TM 2.0.1 Testing
installation : eclipse-SDK-3.3 (I20070625-1500), cdt-4.0.0, emf-2.3.0
RSE install  : Download RSE-2.0.1RC1: RSE-SDK,examples,tests,discovery,terminal
java.runtime : Sun 1.6.0_01-b06
os.name:     : Windows XP 5.1, Service Pack 1
------------------------------------------------
systemtype   : Linux SSH-Only
------------------------------------------------
Comment 1 Martin Oberhuber CLA 2007-09-26 19:04:00 EDT 
Created attachment 79252 [details]
Patch fixing the issue

Attached patch fixes the issue.
Comment 2 Martin Oberhuber CLA 2007-09-26 19:05:19 EDT 
Patch committed:

[204744] Honor encoding in SSH command input field
   SshHostShell.java
Comment 3 Martin Oberhuber CLA 2007-09-26 19:07:56 EDT 
Test case:

Create an "SSH Only" connection
Host > Properties > Set encoding to "UTF-8"
Launch Shell
In shell, enter e.g.

mkdir aölfğŠ
cd aölfğŠ

This fails with RSE 2.0 but works with 2.0.1
Comment 4 Xuan Chen CLA 2007-09-26 20:54:31 EDT 
I tested the following scenarios:

Create an "SSH Only" connection
Host > Properties > Set encoding to "UTF-8"
Launch Shell
In shell, enter :

mkdir aölfŠ
cd aölfŠ

And it worked fine.  folder "aölfŠ", and I was able to change to this newly created directory.
Comment 5 Xuan Chen CLA 2007-09-27 01:09:05 EDT 
Also tested the following scenario in the 2.0.1 driver:

Create an "SSH Only" connection
Host > Properties > Set encoding to "UTF-8"
Launch Shell
In shell, enter :

mkdir aölfŠ
cd aölfŠ