Bug 191599 - Shells should use host encoding
Summary: Shells should use host encoding
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 2.0.1   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
: 180202 (view as bug list)
Depends on: 204744
Blocks: 196301
  Show dependency tree
 
Reported: 2007-06-07 17:54 EDT by Kushal Munir CLA
Modified: 2007-09-26 19:01 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kushal Munir CLA 2007-06-07 17:54:15 EDT 
Shell encoding should honor the host encoding set in the property page of the host or retrieved automatically from the remote system, i.e. it should use IHost.getEncoding(), to interpret shell output. Previously, there was a property page for Shells where users could set the encoding but it was not used.

See bug 179937 for more details.
Comment 1 Kushal Munir CLA 2007-06-07 17:55:40 EDT 
Dave, we discussed this earlier so I'm assigning this to you. I think it's an important bug to fix.
Comment 2 Martin Oberhuber CLA 2007-06-11 08:14:07 EDT 
*** Bug 180202 has been marked as a duplicate of this bug. ***
Comment 3 David McKnight CLA 2007-07-11 14:58:15 EDT 
I've changed the code to make use of the host encoding - the effects local, ssh and dstore shells.
Comment 4 Martin Oberhuber CLA 2007-07-12 11:23:48 EDT 
Wouldn't the same change also be needed for Telnet? It's a clone of SSH but it looks like it TelnetHostShell doesn't observe the encoding right now.
Comment 5 David McKnight CLA 2007-07-12 11:58:58 EDT 
I've made the change for telnet now too.