Community
Participate
Working Groups
Created attachment 79116 [details] example source code It would be nice to have option to jump between subsequent bookmarks in currently open file using shortcut keys, instead of mouse-going to Bookmarks view. Attached is example source code and binary plug-in for your convenience.
Created attachment 79117 [details] example binary
Jacek, you basically want a command for 'Next Bookmark' and 'Previous Bookmark' operations on the file that is currently being edited, correct? I noticed that your sample code seems to restrict the operation to the first couple of bookmarks for the file.
(In reply to comment #2) > Jacek, you basically want a command for 'Next Bookmark' and 'Previous Bookmark' > operations on the file that is currently being edited, correct? I noticed that > your sample code seems to restrict the operation to the first couple of > bookmarks for the file. Correct, works for 10 bookmars and that's due to the keyboard limits :) The only advantage of numbered shortcuts over Next-Prev commands is that you mentally assign numbers to places, instead of kinda scrolling between them. Second, it's rare that people have more than 3-5 bookmarks in one file, so I wouldn't consider this as restriction.
can't wait to see it in M5! :)
Created attachment 86600 [details] Jump to Bookmark v02 Jacek, I've converted your example to a patch that would be more in tune with the ide ... with 2 comments. 1) you would probably re-write your execute(*) method to use HandlerUtil to extract the active editor, it's simpler 2) as it turns out, I'm in the wrong place for this kind of patch anyway, since I can't see the text editors from here. The patch would need to be modified to be applied to the appropriate place in the text hierarchy. PW
(In reply to comment #5) > Created an attachment (id=86600) [details] > Jump to Bookmark v02 > And the bindings would be created with a parameter (the bookmark number for that editor) and you would use event.getParameter("jumpToBookmark.num") to retrieve it. PW
Moving to text for consideration. PW
Jacek, my 3 posts or so to say that the patch would need some more work from you before it could be accepted at any level. But I think you were heading in the correct direction. PW
Paul, thanks for spending your time, I really appreciate that. Indeed my patch wasn't for production. In fact I don't use bookmarks, but the idea was inspired by some eclipse training attendees who were used to similar function in other tool. Now after couple of months this RFE doesn't seem very exciting. Maybe I should better start with "how do people use bookmarks?"... My answer: As I said, I don't use them, because I either work with code that I know very well so Package Explorer and Ctrl+Shift+T are perfect. When I see new code, I'm navigating over stack traces - in a natural way closest to how code is executed. Stack traces are quite hard to store in Bookmarks view, because having more than one stack trace you quickly get confused. Having said that, things that I miss in Bookmarks view are: bookmarks hierarchy, drag'n'drop stack trace to bookmarks, drag'n'drop anything from Outline to Bookmarks, jumping between bookmarks on single click (like in Outline) instead of double click. And probably more... I'd love to see that functionality, but with my time constraints I'm not going to push for it. Instead I found neat idea: let's try with something smaller (this bug). If it gets in, I (others as well) will find time for new improvements. So, Dear CC'd people - how do you use bookmarks? Dear Text Wizards - are we heading in correct direction with this bug?
Bookmarks can be attached to any kind of editor (e.g. GEF) and not just textual ones and hence jumping between bookmarks should also be generic and not just for Text editors. Moving back to UI. Note that in the textual editors you can use Ctrl+. and Ctrl+, to jump between bookmarks (assuming you have selected them in the Next/Previous Annotation tool bar drop down.
In light of that I'd consider making the command part of the org.eclipse.ui.examples.contributions plugin as an example, but I won't be spending any time providing a re-uable jumpToBookmark framework :-) PW
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
