Bug 204141 - [Sync View] AbstractTreeViewerAdvisor : excess if inside getCurrentItem
Summary: [Sync View] AbstractTreeViewerAdvisor : excess if inside getCurrentItem
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M3   Edit
Assignee: Michael Valenta CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-09-20 12:06 EDT by Krzysztof Michalski CLA
Modified: 2007-10-31 05:28 EDT (History)
1 user (show)

See Also:
Michael.Valenta: review+

Attachments
Patch (873 bytes, patch)
2007-09-20 12:12 EDT, Krzysztof Michalski CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Michalski CLA 2007-09-20 12:06:28 EDT 
In AbstractTreeViewerAdvisor#getCurrentItem(TreeViewer viewer)
Below part of code are unnecessary:
if (item != null && item.getItemCount() <= 0) {
return item;
}
Comment 1 Krzysztof Michalski CLA 2007-09-20 12:12:09 EDT 
Created attachment 78868 [details]
Patch
Comment 2 Michael Valenta CLA 2007-09-20 14:46:39 EDT 
Patch looks good
Comment 3 Michael Valenta CLA 2007-09-20 14:46:58 EDT 
Patch released to HEAD
Comment 4 Szymon Brandys CLA 2007-10-31 05:28:13 EDT 
Verified in I20071029-1800 and by a code inspection.