Bug 204051 - attachments don't show if they are incoming like other attributes in task editor
Summary: attachments don't show if they are incoming like other attributes in task editor
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.1   Edit
Assignee: Frank Becker CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed, noteworthy
Depends on:
Blocks:
 
Reported: 2007-09-19 19:46 EDT by Shawn Minto CLA
Modified: 2008-09-29 17:09 EDT (History)
1 user (show)

See Also:

Attachments
patch (5.99 KB, patch)
2008-09-28 14:52 EDT, Frank Becker CLA 		no flags Details | Diff
mylyn/context/zip (2.15 KB, application/octet-stream)
2008-09-28 14:52 EDT, Frank Becker CLA 		no flags Details
New Image (326 bytes, image/gif)
2008-09-28 14:54 EDT, Frank Becker CLA 		no flags Details
patch wit background color (3.63 KB, patch)
2008-09-29 15:02 EDT, Frank Becker CLA 		no flags Details | Diff
mylyn/context/zip (2.72 KB, application/octet-stream)
2008-09-29 15:02 EDT, Frank Becker CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shawn Minto CLA 2007-09-19 19:46:26 EDT 
All of the attributes in the task editor are highlighted if they have changed since the previous version of the task with the exception of the attachments.  Any incomming attachments should be highlighted this same way so that users know what has changed and to maintain UI consistency.
Comment 1 Robert Elves CLA 2008-06-14 01:28:26 EDT 
Need to defer: http://wiki.eclipse.org/index.php/Mylyn/3.0_Plan#Deferred_Items
Comment 2 Steffen Pingel CLA 2008-06-14 02:40:56 EDT 
The attachments section will now expand but new attachments are not yet highlighted.
Comment 3 Frank Becker CLA 2008-09-28 14:52:36 EDT 
Created attachment 113690 [details]
patch
Comment 4 Frank Becker CLA 2008-09-28 14:52:39 EDT 
Created attachment 113691 [details]
mylyn/context/zip
Comment 5 Frank Becker CLA 2008-09-28 14:54:38 EDT 
Created attachment 113692 [details]
New Image

please put that file in
org.eclipse.mylyn.commons.ui/icons/eview16
Comment 6 Steffen Pingel CLA 2008-09-28 18:10:11 EDT 
The additional column in the attachment takes up space and looks a bit odd particularly when there are no incomings. Have you tried setting the background color of the rows that show new attachments to the color used for other attributes with incoming changes?
Comment 7 Frank Becker CLA 2008-09-29 15:02:51 EDT 
Created attachment 113790 [details]
patch wit background color
Comment 8 Frank Becker CLA 2008-09-29 15:02:55 EDT 
Created attachment 113791 [details]
mylyn/context/zip
Comment 9 Steffen Pingel CLA 2008-09-29 17:09:12 EDT 
Excellent! Patch applied with minor modifications: Instead of coupling the attachment table to the task editor page it now only has a reference to the TaskDataModel.