Community
Participate
Working Groups
1. Open the Task View 2. Have a task in the view 3. Right click on it and select Mark Completed 4. Right click on the task again Expected result: The option Mark Completed is disabled Actual result: The option Mark Completed is enabled Mantis: 0016803
*** Bug 205722 has been marked as a duplicate of this bug. ***
Reproducible in PDT 2.0.0 as well Tested on Wix XP Eclipse SDK Version: 3.4.1 Build id: M20080911-1700 debugger - org.zend.php.debug_feature-I20081127 pdt - N20081130 dltk-core-sdk-I-I200811251145-200811251145-incubation [Kalin Yanev kalin.a@zend.com]
I'm changing the product version to 2.0.0 Kalin Yanev kalin.a@zend.com
I think this has been fixed already
Re-tested at PDT-2.2.0.v20100517 The same behavior appear again Have marked complete task if perform again right-context menu over this task again have active Mark Complete menu option See attached screen - Mark_Цomplete_Аctive_Аgain.png Reopened by Teodor Kirkov teodor.k@zend.com
Created attachment 169336 [details] Mark Completed is active even if task is marked as complete
It's not possible to mark PHP Task Tags as completed. This option is always disabled.
Created attachment 262438 [details] Screenshot
Dawid, you are right about PHP Task Tags - currently they cannot be marked, but the other tasks in task view still act like in description (I replaced the screenshot with a new one). Yet I'm not really sure if this is PDT bug or platform issue? Let me know
In this case this is platform bug. From PDT side, we can do nothing. Moving to Platform: Task created by user (Task View => Context Menu => Add Task...), have "Mark Completed" action always enabled.
Issue reproduced in neon RC3 see animation: http://i.imgur.com/qk7WlpN.gifv MarkCompletedHandler is responsible. the "mark done" operation consists in putting a key,value pair: ("done", true) attrs.put(IMarker.DONE, Boolean.TRUE) However, the enablement is not checking whether the selected tasks have all the attribute "done" set to false. A possible solution in declarative way, is: Open org.eclipse.ui.ide/plugin.xml at line 2266, where the handler is defined, Change the <enabledWhen> condition, to consider the value of the attribute. I'm not sure this check is doable in a declarative way. Below you see the current code: <handler class="org.eclipse.ui.internal.views.markers.MarkCompletedHandler" commandId="org.eclipse.ui.ide.markCompleted"> <activeWhen> <with variable="activePart"> <instanceof value="org.eclipse.ui.internal.views.markers.ExtendedMarkersView"/> <test args="org.eclipse.ui.ide.tasksGenerator" property="org.eclipse.ui.ide.contentGenerator"> </test> </with> </activeWhen> <enabledWhen> <iterate ifEmpty="false" operator="and"> <instanceof value="org.eclipse.ui.internal.views.markers.MarkerEntry"/> <test forcePluginActivation="false" property="org.eclipse.ui.ide.editable"> </test> </iterate> </enabledWhen> </handler>
Update: reading the article [#1], I decided to search for IPropertyTester implementations, and I found a couple of property testers explicitly created for MarkersView and Markers: MarkerPropertyTester and MarkersViewPropertyTester. Hence, the extent of the solution is limited to use the existing MarkerPropertyTester implementation to check if "done" [#1] http://www.robertwloch.net/2011/01/eclipse-tips-tricks-property-testers-with-command-core-expressions/
New Gerrit change created: https://git.eclipse.org/r/81931
The proposed change fixes the behavior. See: http://imgur.com/wrPwz1d.png
Created attachment 264423 [details] marker view is now fixed
Gerrit change https://git.eclipse.org/r/81931 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=1fa8a8912202a687fa459ce75dc67a89d1bd58c6
In master now.
