Community
Participate
Working Groups
Build 20020612 - F3 When synchronizing with repo, the compare view doesn't support ctrl-S actions. The save menu must be used instead.
This is a known limitation. Opt to doc it for 2.0
Since this is only a problem in the Synch view and not in a compare editor I suggest to doc this limitation for the Synch viewer. Moved to Team for now.
This is not only a problem in the sync view. It's a problem in any compare editor that chooses to use the local save menu items from the compare framework. For example, Compare With->Latest from Repository. These save menu items are contributed by the compare framework, and should have accelerators attached to them; either that, or hook into the global save action whenever one of the two text merge editors has focus. I could be wrong, but I don't see how Team can fix this. ContentMergeViewer.SaveAction is the class the implements this functionality. Andre, please advise.
James, have you tried to implement your CompareEditor's isSaveNeeded() method so that it returns true whenever there are unsaved changes?
Marking as 2.0.1.
This will not be done in 2.0.1. Marking 2.1
UI has recently put support in -- we should be able to do this now.
From note from Simon: What you need to do... 1) SyncView should adapt to the ISaveablePart (or it can implement - your choice) 2) Implement the doSave(monitor) method to save the "input" 3) Implement the isDirty() method to return the dirty state of the "input" 4) Make sure isSaveAsAllowed() always return false. 5) When the "input" becomes dirty (or non-dirty), the SyncView needs to fire the PROP_DIRTY property (see fireProperty method on WorkbenchPart). When I hacked SyncView to test this new feature, I listened for changes from the "input" and then called fireProperty is it was the dirty state that had changed.
Probably you can use some of the implementation of the CompareEditor in the compare plugin. It adapts the CompareEditorInput to an EditorPart which should be similar to your case.
Will be in I20030304.
I have to reopen this bug report. This is not fixed: 1. select a file in your workspace which is under CVS control 2. compare with revision 3. change some text in the left pane 4. Ctrl+S ==> nothing happens.
I should of tested the ctrl-s in the compare view when fixing this bug. In any case, the intent for this bug was to add support to the sync view and that is fixed in RC2. I have opened another PR for the compare view and are changing the title of this bug. See new bug 35467.
