2023 – No banner graphics in Save As dialog (1GDKM9Y)

Bug 2023 - No banner graphics in Save As dialog (1GDKM9Y)

Summary: No banner graphics in Save As dialog (1GDKM9Y)

Status:	RESOLVED FIXED

Alias:	None

Product:	Platform
Classification:	Eclipse Project
Component:	UI (show other bugs)
Version:	2.0
Hardware:	All All

Importance:	P3 normal (vote)
Target Milestone:	---
Assignee:	Randy Giffen
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2001-10-10 22:24 EDT by Simon Arsenault
Modified:	2002-01-17 12:08 EST (History)
CC List:	1 user (show)

See Also:

Attachments
picture of Save As dialog (471.55 KB, image/bmp) 2002-01-10 12:52 EST, Lynne Kues	no flags	Details
patch file (4.85 KB, patch) 2002-01-11 12:37 EST, Lynne Kues	no flags	Details \| Diff
full image file (2.52 KB, image/gif) 2002-01-11 12:43 EST, Lynne Kues	no flags	Details
basic image file (470 bytes, image/gif) 2002-01-11 12:44 EST, Lynne Kues	no flags	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Simon Arsenault

2001-10-10 22:24:45 EDT

Open an editor on a file
	Select File->Save As... menu item
	Notice the dialog has a white banner at the top with
	nothing in it. It that the expected look?

NOTES:
	RG (5/11/01 2:46:25 PM)
	See 1GD0BXF: ITPUI:ALL - File save as dialog banner area empty

NE (05/28/01 11:14:07 AM)
	Need to be consistent.

Comment 1 DJ Houghton

2001-10-29 17:46:12 EST

PRODUCT VERSION:
	0.105

Comment 2 Lynne Kues

2002-01-10 12:52:51 EST

Created attachment 210 [details]
picture of Save As dialog

Comment 3 Lynne Kues

2002-01-10 18:12:32 EST

Created attachment of Save As dialog.  Inconsistencies as follows:

- dialog has a banner gif without an icon ==> use same gif as for create new 
file
- dialog uses "..." in it's titles ==> get rid of ... in labels
- dialog does not have explanation text like other wizards ==> add an 
explanation

Comment 4 Lynne Kues

2002-01-11 12:37:19 EST

Created attachment 212 [details]
patch file

Comment 5 Lynne Kues

2002-01-11 12:39:01 EST

Patch file doesn't appear to pick up new resource files.  Including new image 
files as attachments.  These files go under /icons/full/wizban and 
/icons/basic/wizban.

Comment 6 Lynne Kues

2002-01-11 12:43:46 EST

Created attachment 215 [details]
full image file

Comment 7 Lynne Kues

2002-01-11 12:44:06 EST

Created attachment 216 [details]
basic image file

Comment 8 Lynne Kues

2002-01-16 16:24:45 EST

Waiting on RG to review.  Reassigning to him.

Comment 9 Randy Giffen

2002-01-17 12:08:28 EST

Reviewed and released the changes

I made the following change to the method comment in SelectionDialog to
follow the JavaDoc pattern we use when overriding methods.

/** 
 * The <code>SaveAsDialog</code> iplementation of this <code>Window</code>
 * method disposes of the banner image when the dialog is closed.
 */
public boolean close() {
	if (dlgTitleImage != null) 
		dlgTitleImage.dispose();
	return super.close();
}