Bug 202172 - [ViewMgmt] Language Switching should update language strings on tabs
Summary: [ViewMgmt] Language Switching should update language strings on tabs
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: IDE (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P5 enhancement with 6 votes (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
: 244298 271874 288342 288412 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-09-04 12:00 EDT by Rich Watts CLA
Modified: 2017-06-20 08:18 EDT (History)
12 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rich Watts CLA 2007-09-04 12:00:37 EDT
Request for new feature that refreshes all the tabs in workbench after language setting changes and workbench opens in the same workspace.


1. Suppose the IDE is in Chinese. 
2.Switch the language to be English. We use the following command to switch language:                                                        
D:\IBM\SDP70\eclipse.exe -nl en_US -product com.ibm.rational.rad.product.ide
for RPT and RSA, you can also use the similar command to do this.       
3. Check the View's tab. You can find only the focused view's tab change to be the new language.  All the other tabs are still in Chinese.
4. Click some view's tab then it will update.
Comment 1 Boris Bokowski CLA 2007-09-06 10:38:30 EDT
The reason for this is that we remember the tab title on shutdown so that we don't have to load the required plug-ins for non-active editors when the Workbench comes up again.

We cannot refresh all tabs at startup since that would cause a delay due to plug-in loading that is probably going to annoy users much more than you are annoyed by the "wrong" tab titles.

Can you close all editors (Ctrl+Shift+F4) and open them again?
Comment 2 Paul Webster CLA 2007-09-06 11:19:04 EDT
So if we switch languages all view tabs would get updated back to their default for that language (i.e. we would not respect any calls to set the part title)?  It is a feature sized request but do-able.

We would not be able to do the same for editors, however.  And then there are concerns that we've wiped out part titles, although one can argue that if you're reset your locale you're ready for a lot of changes anyway.

PW
Comment 3 Boris Bokowski CLA 2007-09-06 16:09:45 EDT
Marking P5 since it seems to me that our time is better spent on other bugfixes or features.  We'd be happy to look at a patch for this of course.
Comment 4 Paul Webster CLA 2008-08-18 08:51:11 EDT
*** Bug 244298 has been marked as a duplicate of this bug. ***
Comment 5 Andre Dubrovsky CLA 2008-08-18 12:49:57 EDT
In opposition to eclipse user is it not unimportant for RCP user.
The user must explicit switch language locale and restart application.
And after it we have not localized strings in the GUI.
It is possible to save locale with then text together in workbench.xml:
... label="View" locale="en" ...
If the locale has been changed, the label must be reloaded for new locale.


Comment 6 Paul Webster CLA 2009-04-17 08:35:19 EDT
As per http://wiki.eclipse.org/Platform_UI/Bug_Triage_Change_2009
Comment 7 Paul Webster CLA 2009-04-17 08:35:40 EDT
*** Bug 271874 has been marked as a duplicate of this bug. ***
Comment 8 Boris Bokowski CLA 2009-04-20 23:24:09 EDT
(In reply to comment #5)
> In opposition to eclipse user is it not unimportant for RCP user.

Like I said, we'd be happy to look at a patch for this. See http://wiki.eclipse.org/Platform_UI/How_to_Contribute
Comment 9 Markus Keller CLA 2009-06-10 04:55:16 EDT
For the Problems view, the title does not even change when the view is closed and then reopened. Probably because it has allowMultiple="true" and stores a separate name for each instance of the view. At least the default view name should also be updated.
Comment 10 Paul Webster CLA 2009-09-02 08:17:27 EDT
*** Bug 288342 has been marked as a duplicate of this bug. ***
Comment 11 Paul Webster CLA 2009-09-03 07:53:13 EDT
*** Bug 288412 has been marked as a duplicate of this bug. ***
Comment 12 Boris Bokowski CLA 2009-11-11 17:32:44 EST
Remy is now responsible for watching the [ViewMgmt] category.
Comment 13 Olivier Thomann CLA 2010-04-27 11:17:50 EDT
Problem and Tasks views are the two views that don't refresh properly when changing the locale.
Comment 14 Remy Suen CLA 2010-04-27 12:10:53 EDT
(In reply to comment #9)
> For the Problems view, the title does not even change when the view is closed
> and then reopened.

This doesn't seem to be a problem on I20100426-0852. Closing and reopening them seems to resolve the problem.

> Probably because it has allowMultiple="true" and stores a
> separate name for each instance of the view.

It doesn't seem like 'allowMultiple' is the culprit here. I tried the 'Properties' view (multi-able since 3.5) and 'Console' view and those get updated when I physically click on them.

I believe the markers views don't get updated because it directly invokes setPartName(String) method in init(IViewSite, IMemento) by retrieving the value from its memento. So even if the tab creation code gets a localized string back, it'll be overridden shortly after when the memento is read.