Community
Participate
Working Groups
1. Create a Hello World plug-in 2. Right-click on the plug-in project and choose PDE Tools > Externalize Strings from the context menu. 3. Accept all defaults in the NLS wizard and press Finish. The wizard will successfully create a new plugin.properties file (great!), however it does not modify the bin.includes key in the plug-in's build.properties file to include this new file (not so great!) This enhancement, along with bug 147621, would go a long way in ensuring a smooth NLS workflow.
adding context, marking for bugday
Created attachment 77591 [details] mylyn/context/zip
I'll pick this one up too Chris, if that's ok?
awesome!
A patch is nearly ready for this one guys. Just had a quick question... If the project is missing a "build.properties" file should we create a default one as part of the "Externalize Strings" operation and subsequently add the "plugin.properties" file to the "bin.includes" key or just skip this part of the operation altogether? If we should create a "build.properties" file, there is currently no clean way to do this (i.e. via a helper class/method) and i would suggest moving the code from "new project operation" out to such a helper class or method (its already duplicated in the "covert to plugin project operation"). Thoughts, suggestions?
Don't worry about creating the build.properties. If it is missing, the user should already have a marker in their project. We do not currently have a single piece of code which does the calculations and creates the file. If we find this scenario causes problems, we can go ahead and refactor code at that time. Hopefully this makes it easier on you :)
Created attachment 79683 [details] Patch Here it is guys. The updated logic is: - We now update the "build.properties" (if present) file to include the newly generated "plugin.properties" file in the "bin.includes" key. - If the "build.properties" file is not present no modifications are made.
thanks! Targetting towards 3.4M3
Great patch. I internalized a string but pretty much left everything the same. very nice Gary.... we're getting fancy now ;)
Created attachment 79689 [details] mylyn/context/zip
thanks again Gary!
ooops, we forgot a case Gary.
Created attachment 79692 [details] org.eclipse.pde.ui.patch
Created attachment 79693 [details] mylyn/context/zip
if you set the localization to be something other than 'plugin' we hardcoded it to plugin still... simply updated the code to be awary of the bundleLocalization :D
> ooops, we forgot a case Gary. I was waiting to see if you would catch that :)
Bauman, you are up at 1:45 a.m. CST?
I was sure the hard coding of "plugin.properties" was wrong and had it on my todo list to revisit and investigate but it got missed / it was 2am! Cheers for the correction Chris :)
> Bauman, you are up at 1:45 a.m. CST? You know keeping track of Chris is a full time, round the clock job ;-)
hah, my late night coding and wine tasting results in interesting things.
Verified on I20071030-0800
