Bug 20169 - Help context ids for External tools
Summary: Help context ids for External tools
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Ant (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P2 normal (vote)
Target Milestone: 3.0 M1   Edit
Assignee: Jared Burns CLA
QA Contact:
URL:
Whiteboard:
Keywords: ui
: 20981 33784 (view as bug list)
Depends on:
Blocks:
 
Reported: 2002-06-13 10:03 EDT by Ryan Cooper CLA
Modified: 2003-05-29 21:38 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Cooper CLA 2002-06-13 10:03:51 EDT 
I was checking on the help context ids used in external tools, and noticed this 
in ToolPreferencePage:

public void createControl(Composite parent) {
	super.createControl(parent);
	// should do something here with the help..	
	/* FIXME
	WorkbenchHelp.setHelp(
		parent,
		new Object[] { IAntHelpContextIds.ANT_PREFERENCE_PAGE });
	*/
}

In IHelpContextIds we have:

public static final String ANT_PREFERENCE_PAGE = PREFIX 
+ "ant_preference_page_context"; //$NON-NLS-1$
public static final String LOG_CONSOLE_PREFERENCE_PAGE = PREFIX 
+ "log_console_preference_page_context"; //$NON-NLS-1$

We should either use the LOG_CONSOLE_PREFERENCE_PAGE as the id for 
ToolPreferencePage or define a TOOL_PREFERENCE_PAGE , and of course the 
Workbench.setHelp(...) should be uncommented.
Comment 1 Darin Wright CLA 2002-11-15 11:19:10 EST 
Need to check Help context Ids for all of external tools.
Comment 2 Darin Wright CLA 2002-11-15 12:07:53 EST 
*** Bug 20981 has been marked as a duplicate of this bug. ***
Comment 3 Darin Swanson CLA 2003-02-14 23:10:52 EST 
The code side of this has been completed...except for the Ant Editor. Need to 
investigate how this is done by the Java editor.

Still need to generate all of the xml etc to test the F1.
Comment 4 Darin Swanson CLA 2003-03-12 14:16:26 EST 
*** Bug 33784 has been marked as a duplicate of this bug. ***
Comment 5 Darin Wright CLA 2003-03-25 09:40:11 EST 
Removing RC4 tag, as no code fixes will go into RC4.
Comment 6 Darin Swanson CLA 2003-04-09 16:47:24 EDT 
All that I know that is left is F1 support from the Ant editor.
Comment 7 Darin Swanson CLA 2003-04-10 17:01:27 EDT 
Added the help for the Ant editor.
Comment 8 Darin Swanson CLA 2003-04-10 17:09:32 EDT 
Please verify Jared.
Comment 9 Jared Burns CLA 2003-04-22 09:43:01 EDT 
F1 help in the editor doesn't work on GTK. Note that it doesn't work in the
Java editor either. This problem is filed as Bug 36153.
Comment 10 Joe Szurszewski CLA 2003-04-22 13:25:04 EDT 
Jared, I don't get anything when I hit F1 in the Ant editor on WinXP.
Comment 11 Jared Burns CLA 2003-04-28 12:41:05 EDT 
Reportedly doesn't work.
Comment 12 Darin Swanson CLA 2003-05-08 16:02:37 EDT 
I versioned and released the org.eclipse.platform.doc.user plugin.
Will be in the next integration build.
Comment 13 Jared Burns CLA 2003-05-14 17:05:39 EDT 
Verified.