Bug 20155 - [preferences] segmented view should be a preference, not a toolbar button
Summary: [preferences] segmented view should be a preference, not a toolbar button
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P2 enhancement (vote)
Target Milestone: 3.3 M2   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords: usability
: 51961 (view as bug list)
Depends on:
Blocks: 10044 34495 72354
  Show dependency tree
 
Reported: 2002-06-13 09:23 EDT by Adam Kiezun CLA
Modified: 2006-09-19 11:50 EDT (History)
6 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Kiezun CLA 2002-06-13 09:23:43 EDT
F3
it's not common to change it often
and it feels like an editor appearance preference - not a toolbar button 
function
(people on the newsgroup were confused by it too)
Comment 1 Dirk Baeumer CLA 2002-06-14 11:27:43 EDT
Not for 2.0
Comment 2 Dirk Baeumer CLA 2002-07-22 10:47:11 EDT
Reopening for 2.1 consideration
Comment 3 Gunnar Wagenknecht CLA 2002-12-10 06:12:56 EST
The toolbar button is not ver intuitive. See bug 27884. I must have clicked 
this button without notice. I've worked a whole weekend without finding an 
option to turn this of. It was really terrible.
Comment 4 Adam Kiezun CLA 2002-12-10 06:16:43 EST
not an enhancement - it's a usability bug
Comment 5 Adam Kiezun CLA 2003-01-22 11:26:52 EST
see also bug 29975
Comment 6 Jerome Lanneluc CLA 2003-02-10 11:07:50 EST
Actually I would not want that. I usually have it on, but I often turn it 
temporary off to do a global find/replace in the file. So having it as a toobar 
button is convenient for me.
Comment 7 Russell Gonsalves CLA 2003-02-10 12:32:37 EST
I just encountered it with M5.  Not sure how it got turned on but I spent a 
frustrating (short) period of time, before I posted on the newsgroup.  A 
prompt reply from Adam helped.

Doesn't matter to me which way it's done (preference / toolbar button) as long 
as when I shut Eclipse down and bring it up the setting is maintained (which I 
believe it is from my minimal experimentation).  Do I take it the setting is 
stored in the "workspace" directory in both cases?  If not, I'll probably have 
a different opinion.

Thanks,

Russell
Comment 8 Simon Tardell CLA 2003-02-11 04:51:51 EST
If it is turned into a preference, then the button should be there in the 
toolbar if the preference is on (that is, if you normally view element-by-
element, there should be a way to temporarily snap out of it and view the whole 
type (some people say "file"...;)).
Comment 9 Jim Sculley CLA 2003-02-12 21:18:03 EST
I agree with Simon.  This is not an 'either or' preference.  It changes
depending on what you happen to be doing.  Moving it to preferences would be
like moving the buttons at the top of the 'Outline' view into preferences.
Comment 10 Russell Gonsalves CLA 2003-02-12 22:11:39 EST
Never did get an answer to my query as to whether the setting is persisted 
between Eclipse invocations (appears to be so, but I thought I'd ask).

Thanks,

Russell
Comment 11 Dani Megert CLA 2003-09-29 06:11:56 EDT
Adam, this not a bug and I agree with Jerome that often you change between
segmented and non-segmented mode.

Russel, it is persisted.

No plans to change this for 3.0
Comment 12 Gunnar Wagenknecht CLA 2003-09-29 07:52:44 EDT
I disagree. It's definitly a usability bug. Please see comment 3 and comment 7 
and think about the resolution "resolved later". 

It's hanging around here for a long time now and your suggested solution: "it's 
not a bug - it's a feature" doesn't seem to fit as much as possible use cases 
like a bug solution should be.

The button might be a nice-to-have for some guys and its usage might be 
intuitive but the persistence of this setting should not be handled by the 
toolbar button. Every user not confronted with this button/functionallity 
before will never know how to disable it if it was accidentally enabled because 
he will simply not recognize that a toolbar button configures a 
persistent "preference" of the Java editor.
Comment 13 Arnim Sahl CLA 2003-09-29 14:01:26 EDT
I doubt, that it is a good idea, to configure the segmented view in the 
preferences. If not, it might be in a tool bar, but which one. As far as I can 
see, neither a) the perspectives nor b) the editor view as a whole nor (just as 
an idea) c) a file tab itsself have a tool bar for now and everything depends 
on new features of 3.0, where I do not know enough about. Maybe the member view 
toolbar in the Java Browsing perspective might be a good place to override an
overall setting. 

I was thinking of submitting a bug when I found 10044, whose original idea was, 
that the IDE overall setting is bad and I agree, that it is important to change 
that really quick.
Comment 14 Dani Megert CLA 2003-09-30 03:49:51 EDT
Regarding comment 13: moving the toggle to a view is not a good idea since many
people have an editor only setup. Having the setting in the editor tab might be
a good idea.

For those of you that simply want to get rid of the toggle in the tool bar
(using 3.0):
1. Window > Customize Perspective
2. Commands tab
3. Uncheck "Editor Presentation"
Comment 15 Dani Megert CLA 2004-04-29 06:20:26 EDT
*** Bug 51961 has been marked as a duplicate of this bug. ***
Comment 16 Markus Keller CLA 2005-08-08 11:19:58 EDT
Why not add a preference *and* leave the button in the toolbar? We already have
that for Mark Occurrences, and we rarely get questions about how to disable that
feature. Many of the people who run into this usability bug write that they
searched all preferences but found nothing.

The checkbox could be on 'Preferences > Java > Editor'. Maybe even better would
be the 'Preferences > Java > Editor > Folding' page, where the folding options
could be grayed when the segmented mode is active.
Comment 17 Markus Keller CLA 2006-06-13 06:26:00 EDT
Considering all the support expenses this toolbar button has caused, I think the "Editor Presentation" action group should be disabled by default. Adding a preference would still be good.
Comment 18 Dani Megert CLA 2006-06-30 05:37:20 EDT
.
Comment 19 Dani Megert CLA 2006-06-30 05:38:03 EDT
We will solve this usabilty problem for 3.3.
Comment 20 Daniel Serodio CLA 2006-06-30 10:17:33 EDT
+1 for keeping the toolbar button
Comment 21 Dani Megert CLA 2006-06-30 11:49:36 EDT
Out of the box it will probably no longer be visible but you can enable the action set to bring the button back to the toolbar.
Comment 22 Dani Megert CLA 2006-08-30 12:24:29 EDT
Fixed in HEAD:
- added preference to Java > Editor preference page
- disabled the action set per default
  ==> those who like and often use the tool bar button can simply go and enable
      the 'Editor Presentation' action set


Available in builds > N20060830-0010.
Comment 23 Benno Baumgartner CLA 2006-09-19 11:42:13 EDT
starting to verify...
Comment 24 Benno Baumgartner CLA 2006-09-19 11:50:55 EDT
verified in I20060919-0010