Bug 201538 - Action "update jobs statuses" doesn't download status for DONE, ABORTED... jobs
Summary: Action "update jobs statuses" doesn't download status for DONE, ABORTED... jobs
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Geclipse (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Szymon Mueller CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on: 202154
Blocks:
  Show dependency tree
 
Reported: 2007-08-29 05:24 EDT by Mariusz Wojtysiak CLA
Modified: 2014-01-09 16:18 EST (History)
0 users

See Also:

Attachments
Patch for eu.geclipse.core (3.62 KB, patch)
2007-09-12 06:18 EDT, Szymon Mueller CLA 		aog-ecl: iplog+
Details | Diff
Patch for eu.geclipse.ui (3.91 KB, patch)
2007-09-12 06:23 EDT, Szymon Mueller CLA 		aog-ecl: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mariusz Wojtysiak CLA 2007-08-29 05:24:48 EDT 
1. Submit any job and wait till job status will be DONE or ABORTED
2. In Jobs view select this job and from context-menu start "Update selected job status"
Result:
- status is not downloaded (Last update time is not refreshed). 

Reason:
This is because for DONE jobs, updater cannot be found (is not created)

Should be:
Status should BE always downloaded when user started this action manually (on demand) regardless of current job-status

Solution discussed with Pawel:
- for action "Update selected job status" called by user (not called in the background by periodical updater), there should be dedicated one special updater (not connected with given job)
- this updater should download selected jobs one by one (not all simultaneously)
- this updater should show progress monitor dialog during downloading
Comment 1 Szymon Mueller CLA 2007-09-04 10:10:44 EDT 
Bug fixed, see bug id=202154. Please close this item.
Comment 2 Szymon Mueller CLA 2007-09-12 06:13:24 EDT 
Patches fix some issues with job status updates:
1. Informs listeners of the updates jobs if status has been changed.
2. Fixes ConcurentModificationException which occured when you changed selection in Jobs View when manual status updates were in progress.
3. Removed excessive constructor from UpdateJobStatusAction.
Comment 3 Szymon Mueller CLA 2007-09-12 06:18:51 EDT 
Created attachment 78162 [details]
Patch for eu.geclipse.core

Modified classes:
1. JobStatusUpdater - added method statusUpdated( IGridJobStatus ) which is fired when job's status was changed outside of the updater.
2. JobManager - added method jobStatusChanged( IGridJob ) which searches updaters for updater of the given job and executes statusUpdated( IGridJobStatus ) for that updater.
3. IGridJobManager - method jobStatusChanged( IGridJob )
Comment 4 Szymon Mueller CLA 2007-09-12 06:23:55 EDT 
Created attachment 78163 [details]
Patch for eu.geclipse.ui

Modified classes:
1. UpdateJobStatusAction - removed constructor UpdateJobStatusAction( IWorkbenchWindow) and modified run method to resolve ConcurentModifyException.
2. JobViewActions - changed to constructor without parameters for new UpdateJobStatusAction.
Comment 5 Szymon Mueller CLA 2007-09-21 05:10:14 EDT 
Bug fixed, se above comments.
Comment 6 Mariusz Wojtysiak CLA 2007-09-21 10:34:45 EDT 
Job status is now downloaded on every user call. Great!
Unfortunatelly views sometimes are not refreshed, but it's another bug: 199874
So this bug can be closed.
Comment 7 Ariel Garcia CLA 2009-05-03 10:04:15 EDT 
Comment on attachment 78163 [details]
Patch for eu.geclipse.ui

Applied by Mariusz
Comment 8 Ariel Garcia CLA 2009-05-03 10:04:23 EDT 
Comment on attachment 78162 [details]
Patch for eu.geclipse.core

Applied by Mariusz