Bug 201386 - warn if commiting from workspace with compile error
Summary: warn if commiting from workspace with compile error
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.3   Edit
Hardware: All All
: P5 enhancement (vote)
Target Milestone: ---   Edit
Assignee: platform-cvs-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2007-08-28 04:17 EDT by Benno Baumgartner CLA
Modified: 2019-09-06 16:14 EDT (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Benno Baumgartner CLA 2007-08-28 04:17:15 EDT
I20070821-0800

Given a java project shared in CVS with classes:
package test;
public class E01 {
	public static String NAME= "id";
}
package test;
public class E02 {
	public String toString() {
		return E01.NAME;
	}
}
1. Rename 'NAME' to 'ID'
2. 'Override and update' E02.java
3. Commit E01.java
Is:
 E01.java is committed
Should:
 A big fat red blinking dialog should yell at me that I'm a f*** idiot if I do commit this.

Debug does the same when lunching if an error in the workspace exists.
Comment 1 Tomasz Zarna CLA 2007-08-28 05:16:30 EDT
I belive that all users are aware of what they are doing when committing. But if I'm wrong and if you have strong feelings
about the dialog we could consider addressing this item. I would just slightly change the message ;)
Comment 2 Benno Baumgartner CLA 2007-08-29 05:25:59 EDT
(In reply to comment #1)
> I belive that all users are aware of what they are doing when committing. But
> if I'm wrong and if you have strong feelings
> about the dialog we could consider addressing this item. I would just slightly
> change the message ;)
> 

Yes, I do feel kinda strong about this, and yes, I usually know what I'm doing, but everyone does make mistakes sometimes (especially on Fridays 5 o'clock;-) The tool should try to prevent me doing so.

But I agree that we should choose another message...

Comment 3 Szymon Brandys CLA 2007-08-29 05:38:18 EDT
(In reply to comment #0)
I think it works differently for debug. You should be aware that you are trying to launch an app with errors. In the cvs case, people very often commit their work with errors on purpose (e.g. in the end of the day).

On the other hand, the sync view shows errors. So why should we show an extra dialog?

Comment 4 Benno Baumgartner CLA 2007-08-29 08:33:12 EDT
(In reply to comment #3)
> I think it works differently for debug. You should be aware that you are trying
> to launch an app with errors. In the cvs case, people very often commit their
> work with errors on purpose (e.g. in the end of the day).

The dialog should have a 'Do not show again' check box. I don't think that people committing errors on purpose very often, at least not if they work in a team.

> 
> On the other hand, the sync view shows errors. So why should we show an extra
> dialog?
> 

See my steps from comment #0: Once you 'Override and update' E02.java you have a compile error in E02, but the sync view does not show E02 because it has no outgoing changes... You can only see the compile errors in the problems view and package explorer, both are fast views in my environment.

CVS shows a warning dialog if you try to commit a resource with errors. This is the unnecessary case because in this case the user can see the error marker in the sync view. In my case the user can not.
Comment 5 Tomasz Zarna CLA 2007-10-09 11:38:32 EDT
Now I can see your point Benno, it does reasonable to me. I hope we'll have enough manpower to address this issue in the future. Do you think the case should be covered with the same preference? I do.
Comment 6 Benno Baumgartner CLA 2007-10-10 04:15:34 EDT
(In reply to comment #5)
> Now I can see your point Benno, it does reasonable to me. I hope we'll have
> enough manpower to address this issue in the future. Do you think the case
> should be covered with the same preference? I do.

I would be satisfied with either way. But if you reuse the existing options then you have to rename them: 'Commit with errors in workspace' (default prompt) and 'Commit with warnings in workspace' (default yes)
Comment 7 Eclipse Webmaster CLA 2019-09-06 16:14:01 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.