Bug 201144 - [context] support focusing the Bookmarks view
Summary: [context] support focusing the Bookmarks view
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P4 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Jakub Jurkiewicz CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, contributed, helpwanted
Depends on:
Blocks:
 
Reported: 2007-08-24 16:45 EDT by Ducky Sherwood CLA
Modified: 2008-11-04 21:33 EST (History)
1 user (show)

See Also:

Attachments
mylyn/context/zip (1.59 KB, application/octet-stream)
2007-10-04 10:49 EDT, Eugene Kuleshov CLA 		no flags Details
Patch attachement (3.49 KB, patch)
2007-10-22 08:40 EDT, Jakub Jurkiewicz CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ducky Sherwood CLA 2007-08-24 16:45:45 EDT 
Build ID: I20070621-1340

When I switch from working on one task to another, I'd like it if my bookmarks also switched.  In other words, I do *not* want to see bookmarks that I set when a different task was active.
Comment 1 Mik Kersten CLA 2007-09-11 01:31:51 EDT 
This is a straightforward feature to add, since we have an almost identical mechanism working for the Eclipse Tasks view, whose contents are IMarker's very similar to bookmarks.  The community has not expressed much interest in supporting the Bookmarks view, so marking as helpwnated.
Comment 2 Jakub Jurkiewicz CLA 2007-10-04 05:45:49 EDT 
I'd like to take of it for the coming bugday. I have always been interested in seeing how the context mechanism works and this bug looks perfect to do this.

Could you just say what I should start looking at?
Comment 3 Eugene Kuleshov CLA 2007-10-04 10:49:00 EDT 
Here is the task context that should help you to get started.
Comment 4 Eugene Kuleshov CLA 2007-10-04 10:49:02 EDT 
Created attachment 79728 [details]
mylyn/context/zip
Comment 5 Mik Kersten CLA 2007-10-10 22:38:59 EDT 
Jakub: as Eugene points out with the attached context, the way to do this is to replicate what we have already done for the Tasks view (added support for filtering markers and the corresponding action) since the Bookmarks view is just a markers view that shows the Bookmark type of marker.
Comment 6 Jakub Jurkiewicz CLA 2007-10-15 06:03:14 EDT 
(In reply to comment #5)
> Jakub: as Eugene points out with the attached context, the way to do this is to
> replicate what we have already done for the Tasks view (added support for
> filtering markers and the corresponding action) since the Bookmarks view is
> just a markers view that shows the Bookmark type of marker.
> 
Thanks for the tips. I will have a look at this when I have some more time (hopefully this week).
Comment 7 Jakub Jurkiewicz CLA 2007-10-22 08:40:22 EDT 
Created attachment 80871 [details]
Patch attachement

Please take a look at the patch.
Comment 8 Jakub Jurkiewicz CLA 2007-10-22 08:43:27 EDT 
Is it possible to create super class for classes like FocusTaskMarkersViewAction, FocusProblemsListAction (and probably the class from the patch I attacheched)? There is some code repetition, which could be easily avoid.
Comment 9 Eugene Kuleshov CLA 2007-10-26 05:38:16 EDT 
FWIW, I've tested this manually and it look really nice. It would be a great BugDay contribution (this Friday).
Comment 10 Jakub Jurkiewicz CLA 2007-10-26 07:54:18 EDT 
This was my intention to make it as the bugday contribution.
Comment 11 Mik Kersten CLA 2007-11-01 17:43:41 EDT 
Patch applied and verified.  Very nice Jakub, dziekujemy!
Comment 12 Mik Kersten CLA 2007-11-01 17:44:15 EDT 
Done.  Note that bug 205548 is related.