Community
Participate
Working Groups
We plan to create our own rendering by extending from TraditionalRendering. To do this, we need to refactor the Traditional Rendering code a little bit and to change some methods from protected to public. Please review the attached changes.
Created attachment 76681 [details] Refactoring
Created attachment 76682 [details] Refactoring
Created attachment 76683 [details] Refactoring
Created attachment 81737 [details] additional changes for Rendering.java Allow extensions to provide custom handling of debug devents
Created attachment 81738 [details] TraditionalMemoryByte.java Move TraditionalMemoryByte class from TraditionalRendering.java to a separate file
Created attachment 81742 [details] changes in TraditionalRendering.java
Created attachment 81743 [details] changes in DataPane.java
Please attach a patch. Without a patch, accurately determining the changes is problematic.
(In reply to comment #8) > Please attach a patch. Without a patch, accurately determining the changes is > problematic. I have included the changes for TraditionalRendering.java, DataPane.java, Rendering.java and TraditionalMemoryByte.java
Created attachment 81768 [details] patch for DataPane.java
Created attachment 81769 [details] patch for Rendering.java
Created attachment 81770 [details] patch for TraditionalRendering.java
Created attachment 81771 [details] new file TraditionalMemoryByte.java Moved TraditionalMemoryByte to a separate file
Created attachment 81782 [details] patch for Rendering.java
Created attachment 82132 [details] patch for Rendering.java (+committed, +logged)
Created attachment 82133 [details] patch for AbstractPane.java (+committed, +logged)
Created attachment 82134 [details] patch for DataPane.java (+committed, +logged)
I've reviewed this patch. It looks good. I'm ready to commit it, but I need to discuss timing with Pawel.
Created attachment 82219 [details] patch for AddressPane.java (+committed, +logged)
Created attachment 82223 [details] patch for TextPane.java (+committed, +logged)
Ted, I just added two more files for you to review. They allow extensions to peform their own coloring
Alain, the proposed changes (sans some comments) have been committed to HEAD with one exception. You requested that we expose selection by means of three new methods to Rendering.java: + // added these methods to allow subclasses to access the selection + public BigInteger getSelectionStart() + { + return this.getSelection().getStart(); + } + + public BigInteger getSelectionEnd() + { + return this.getSelection().getEnd(); + } + + public boolean isAddressSelected(BigInteger address) + { + return this.getSelection().isSelected(address); + } Instead, to better allow for the selection to be represented by more than a single BigInteger in the future, I have exposed the selection by addition of an IMemorySelection interface. Rendering.getSelection() now returns IMemorySelection instead of Rendering.Selection. Please verify.
Created attachment 87173 [details] patch AbstractPane.java (+committed, +logged) additional changes
Created attachment 87176 [details] new file (+committed, +logged)
Created attachment 87177 [details] new file (+committed, +logged)
Created attachment 87178 [details] additonal patch for Rendering.java additional changes
Created attachment 87179 [details] additional patch for TraditionalRendering.java additonal changes
Ted, please review the latest patches I submitted. Thanks!
hi Alain, Thanks for the patches! I have two requests: 1) We should file this request under a new bugzilla, since this one is already fixed/resolved. 2) When you create the patch, use the workspace as the root. This will result in a single patch file with all of your changes. Right click on the project in the package explorer. Team -> Create Patch File: patchname.txt In the "Changes" list, all of your modified files should be checked. Next select Unified select Workspace Finish ted
