Bug 20054 - [Contributions] [Services] unable to register ruler context menu for MultiPageEditorPart
Summary: [Contributions] [Services] unable to register ruler context menu for MultiPag...
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 22464 (view as bug list)
Depends on:
Blocks:
 
Reported: 2002-06-12 13:12 EDT by Kit Lo CLA
Modified: 2019-09-06 15:38 EDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kit Lo CLA 2002-06-12 13:12:10 EDT 
In a MultiPageEditorPart with a TextEditor as one of the pages, the site 
created for the TextEditor is a MultiPageEditorSite and the part info in the 
site is a MultiPageEditorPart. When the TextEditor uses the site to register 
the ruler context menus, it failed because 
AbstractRulerActionDelegate.setActiveEditor() checks if fEditor instanceof 
ITextEditor.

As a result of this problem, the Add/Remove Bookmark/Task ruler context menus 
in a TextEditor within a MultiPageEditorPart are not functioning.
Comment 1 Nick Edgar CLA 2002-06-13 11:27:23 EDT 
To solve this properly would require a fairly major redesign of 
MultiPageEditorPart, which we will be unable to do for 2.0.
Comment 2 Kit Lo CLA 2002-07-15 09:47:02 EDT 
Any suggestion on how to workaround the problem in 2.0?
Comment 3 Nick Edgar CLA 2002-07-15 11:42:07 EDT 
I know of know workaround for this.  The action contribution mechanism assumes 
that the actions are being contributed to the top level editor.
Comment 4 Nick Edgar CLA 2002-07-15 11:44:33 EDT 
PDE seems to have worked around this in the plugin.xml editor's source page.
The code in PDEEditorContributor.setActiveEditor(IEditorPart) tests whether the 
source page is active, and if so calls IWorkbenchPage.activate(IWorkbenchPart) 
on the nested editor.  This is not a recommended workaround, and has unwanted 
side effects as noted in bug 19361.

Randy, any ideas?
Comment 5 Andrew Irvine CLA 2002-10-10 13:19:06 EDT 
*** Bug 22464 has been marked as a duplicate of this bug. ***
Comment 6 Douglas Pollock CLA 2004-11-01 13:10:08 EST 
Adding Stefan, to consider with his services work....
Comment 7 Nick Edgar CLA 2004-11-01 13:40:16 EST 
cc'ing Kai too, as this is a concrete occurrence of where the editor makes
assumptions about its context (not that it has a choice currently <g>).
Comment 8 Michael Van Meekeren CLA 2006-04-21 13:56:50 EDT 
Moving Dougs bugs
Comment 9 Paul Webster CLA 2007-04-05 19:01:38 EDT 
Assigning to component owner
PW
Comment 10 Eclipse Webmaster CLA 2019-09-06 15:38:05 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.