Bug 199561 - [efs][dstore] Eclipse hangs when creating a file on dstore-backed remote project, or dbl clicking / moving empty file
Summary: [efs][dstore] Eclipse hangs when creating a file on dstore-backed remote proj...
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 2.0   Edit
Hardware: All All
: P1 critical (vote)
Target Milestone: 2.0.1   Edit
Assignee: Martin Oberhuber CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 187690
  Show dependency tree
 
Reported: 2007-08-10 09:19 EDT by Martin Oberhuber CLA
Modified: 2007-08-10 09:30 EDT (History)
0 users

See Also:
mober.at+eclipse: review? (dmcknigh)
mober.at+eclipse: review? (xuanchen)

Attachments
Simple patch fixing the issue (1.70 KB, patch)
2007-08-10 09:23 EDT, Martin Oberhuber CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2007-08-10 09:19:23 EDT 
In RSE Perspective, Connect to Linux-dstore host.
Select a folder, right-click > Create Remote Project.
Switch to Resource perspective.
Select the remote project, right-click > New > Folder.
  Name "aaa bbb", OK.

All of Eclipse hangs.
Comment 1 Martin Oberhuber CLA 2007-08-10 09:23:26 EDT 
Created attachment 75839 [details]
Simple patch fixing the issue

The problem is, that the DStoreInputStream waits until > 0 bytes are received, which never happens in case of zero-length-file.

Attached patch is a quick hack to fix the issue. I think that it must be improved in order to also handle error situations: the waitForTempFile() loop must exit in case any error is returned from the dstore side, such as host disconnect.
Comment 2 Martin Oberhuber CLA 2007-08-10 09:25:00 EDT 
Committed the patch to fix the original issue:

[199561][efs][dstore] Eclipse hangs when manipulating empty file
   DStoreInputStream.java  1.2

Dave and Xuan please review and improve the fix in order to deal with other error situations, as described in comment #1.