Bug 199450 - Ignored Resources preference page should describe patterns
Summary: Ignored Resources preference page should describe patterns
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M2   Edit
Assignee: Michael Valenta CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-08-09 11:44 EDT by Markus Keller CLA
Modified: 2007-09-19 07:11 EDT (History)
4 users (show)

See Also:
Szymon.Brandys: review+
Michael.Valenta: review+


Attachments
Patch is a response for Markus suggestions (1.18 KB, patch)
2007-08-31 13:21 EDT, Krzysztof Michalski CLA
no flags Details | Diff
Proposition of changes 002 (4.33 KB, patch)
2007-09-11 07:12 EDT, Krzysztof Michalski CLA
no flags Details | Diff
Patch is response for Simon's comment (4.34 KB, patch)
2007-09-12 12:02 EDT, Krzysztof Michalski CLA
no flags Details | Diff
Patch is response for Simon's comments (4.34 KB, patch)
2007-09-13 04:17 EDT, Krzysztof Michalski CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2007-08-09 11:44:34 EDT
I20070809-0010

The Team > Ignored Resources preference page should describe what patterns are supported. Problems:

- Preference page description talks about "resource name patterns", should be "resource name or path patterns"

- "Add Pattern..." dialog:
  - dialog title should be "Add Pattern" or "Add Ignore Pattern" (same as button name)
  - should describe what wildcards are available and how paths are resolved (e.g. does /*/a/* only match files in /xyz/a/, or also in /x/y/z/a/b/c/ , or are these full Ant patterns with **, etc. ?)
Comment 1 Tomasz Zarna CLA 2007-08-09 12:10:03 EDT
Markus, do you mind if we put an information about wildcards into the page's context help (under F1)?
Comment 2 Markus Keller CLA 2007-08-09 12:51:03 EDT
> Markus, do you mind if we put an information about wildcards into the page's
> context help (under F1)?

If you add the complete reference to the context help, that's fine with me. But I still think the dialog should
- tell that name or path patterns can be entered
- tell which wildcard characters are supported, like e.g. the Package Explorer's filers dialog:

"Enter a name or path pattern (* = any string, ? = any character):"
Comment 3 Krzysztof Michalski CLA 2007-08-31 13:21:04 EDT
Created attachment 77488 [details]
Patch is a response for Markus suggestions
Comment 4 Szymon Brandys CLA 2007-09-05 08:39:10 EDT
I'm not sure if this new label is more clear than the last one. I would make the label simple like "Add a resource name pattern" and add the help to the dialog with samples or I would add more examples in brackets at least.
Comment 5 Michael Valenta CLA 2007-09-05 08:48:21 EDT
As a label, I think I would prefer Markus suggestion. However, I agree that we should add some help to give some examples of how to specify name and path patterns.
Comment 6 Krzysztof Michalski CLA 2007-09-11 07:12:41 EDT
Created attachment 78052 [details]
Proposition of changes 002
Comment 7 Szymon Brandys CLA 2007-09-12 05:29:20 EDT
There are some errors in the help (F1) like "matches all .doc file in" instead of "matches all .doc files in".

We should open a new bug for updating "Creating a global ignore pattern" in the help.

I would add a help icon in the bottom-left corner of the dialog. Maybe it would be good to open a bug for InputDialog to add the help button.
Comment 8 Krzysztof Michalski CLA 2007-09-12 12:02:50 EDT
Created attachment 78197 [details]
Patch is response for Simon's comment
Comment 9 Krzysztof Michalski CLA 2007-09-13 04:17:16 EDT
Created attachment 78284 [details]
Patch is response for Simon's comments
Comment 10 Michael Valenta CLA 2007-09-13 11:46:02 EDT
Patch released to HEAD
Comment 11 Szymon Brandys CLA 2007-09-18 05:01:18 EDT
Verified in I20070917-1300.
Comment 12 Markus Keller CLA 2007-09-19 07:11:12 EDT
(In reply to comment #7)
> We should open a new bug for updating "Creating a global ignore pattern" in the
> help.
I couldn't find this bug report.

> I would add a help icon in the bottom-left corner of the dialog. Maybe it would
> be good to open a bug for InputDialog to add the help button.
I agree. Do we have a bug for this?