Bug 199366 - IRC Connection Wizard filters out # character
Summary: IRC Connection Wizard filters out # character
Status: CLOSED FIXED
Alias: None
Product: ECF
Classification: RT
Component: ecf.core (show other bugs)
Version: 1.0.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: ecf.core-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-08-09 02:18 EDT by Robert Konigsberg CLA
Modified: 2008-05-18 19:41 EDT (History)
2 users (show)

See Also:

Attachments
Fixes bug 199366 (895 bytes, patch)
2007-08-22 01:13 EDT, Abner Ballardo CLA 		no flags Details | Diff
mylyn/context/zip (962 bytes, application/octet-stream)
2007-08-22 01:13 EDT, Abner Ballardo CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Konigsberg CLA 2007-08-09 02:18:37 EDT 
When using the ECF connection wizard to connect to the IRC channel, I type a connect ID of konigsberg@irc.freenode.net/#eclipse. When I go back to reconnect, it displays as konigsberg@irc.freenode.net/eclipse, without the #.
Comment 1 Abner Ballardo CLA 2007-08-22 01:13:23 EDT 
Created attachment 76608 [details]
Fixes bug 199366

IRCConnectWizardPage.getConnectID() method cleans the conection ID (removes all '#'), so, I've tested the wizard without cleaning the conection ID and everything worked fine. Can anyone else confirm this?
Comment 2 Abner Ballardo CLA 2007-08-22 01:13:26 EDT 
Created attachment 76609 [details]
mylyn/context/zip
Comment 3 Scott Lewis CLA 2007-08-22 01:21:13 EDT 
(In reply to comment #1)
> Created an attachment (id=76608) [details]
> Fixes bug 199366
> 
> IRCConnectWizardPage.getConnectID() method cleans the conection ID (removes all
> '#'), so, I've tested the wizard without cleaning the conection ID and
> everything worked fine. Can anyone else confirm this?
> 

Have you tried it with multiple channels?

e.g.

irc.freenode.net/#eclipse-dev,#eclipse-ecf,#eclipse-soc
Comment 4 Abner Ballardo CLA 2007-08-22 01:41:22 EDT 
 (In reply to comment #3)
> 
> Have you tried it with multiple channels?
> 

No, I haven't,... there is a problem with multiple channels. I'll work on that.

If we fix this bug, we'll fix bug 195690
Comment 5 Scott Lewis CLA 2007-08-22 01:51:25 EDT 
(In reply to comment #4)
>  (In reply to comment #3)
> > 
> > Have you tried it with multiple channels?
> > 
> 
> No, I haven't,... there is a problem with multiple channels. I'll work on that.
> 
> If we fix this bug, we'll fix bug 195690
> 

I'll fix this right now.  The logic is in IRCUI.getRoomsForTarget.  No need for you to deal with it.  Thanks.
Comment 6 Scott Lewis CLA 2007-08-22 02:40:53 EDT 
Fixed.  Thanks Abner for the patch.  IP log updated.
Comment 7 Scott Lewis CLA 2008-05-18 19:41:05 EDT 
closing.