Bug 195690 - [irc] Support channel names with form '##channel' in connect dialog
Summary: [irc] Support channel names with form '##channel' in connect dialog
Status: RESOLVED FIXED
Alias: None
Product: ECF
Classification: RT
Component: ecf.ui (show other bugs)
Version: 1.0.0 Release   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Chris Aniszczyk CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted
Depends on:
Blocks:
 
Reported: 2007-07-06 14:45 EDT by Scott Lewis CLA
Modified: 2007-08-23 01:35 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Scott Lewis CLA 2007-07-06 14:45:02 EDT 
Currently IRC channel names of form <username>@<hostname>/#channel work in connect dialog to connect directly to #channel once logged in.  The 1.0.0 version does not, however, support <username>@<hostname>/##channel channel names because of the use of '#' in typical URL syntax (as a path#fragment separator).

Note that a workaround is to connect to 

<username>@<hostname>/

and then enter /join ##channel in the entry area at bottom.
Comment 1 Chris Aniszczyk CLA 2007-07-15 16:38:26 EDT 
I'll put this on my plate
Comment 2 Abner Ballardo CLA 2007-08-22 01:26:11 EDT 
The patch attached on bug 199366 also fixes this bug
Comment 3 Scott Lewis CLA 2007-08-22 02:42:25 EDT 
Fixed along with bug 199366 via patch attached to 199366.
Comment 4 Abner Ballardo CLA 2007-08-22 17:30:28 EDT 
I've test this bug. The channel name '##foobar' is changed to '#%23foobar'. In IRCUI.getRoomsForTarget() method, Is it posible to replace all '%23' with '#'?
Comment 5 Scott Lewis CLA 2007-08-22 17:34:22 EDT 
(In reply to comment #4)
> I've test this bug. The channel name '##foobar' is changed to '#%23foobar'. In
> IRCUI.getRoomsForTarget() method, Is it posible to replace all '%23' with '#'?
> 

Yeah, seems like a good idea.  Could you produce such code? (that can run on 1.4...I forget when String.replaceAll was actually introduced).
Comment 6 Scott Lewis CLA 2007-08-23 01:09:42 EDT 
(In reply to comment #4)
> I've test this bug. The channel name '##foobar' is changed to '#%23foobar'. In
> IRCUI.getRoomsForTarget() method, Is it posible to replace all '%23' with '#'?
> 

OK, I've fixed this and committed to HEAD.  Please verify again.
Comment 7 Abner Ballardo CLA 2007-08-23 01:35:24 EDT 
 (In reply to comment #6)
> (In reply to comment #4)
> > I've test this bug. The channel name '##foobar' is changed to '#%23foobar'. In
> > IRCUI.getRoomsForTarget() method, Is it posible to replace all '%23' with '#'?
> >
> 
> OK, I've fixed this and committed to HEAD.  Please verify again.

I couldn't read comment 5 until now :( 

I tested it, and everything works fine.