Bug 199014 - [ant templates]Invalid ant templates: target1 & buildFile1
Summary: [ant templates]Invalid ant templates: target1 & buildFile1
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Ant (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 RC1   Edit
Assignee: Darin Wright CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-08-07 04:23 EDT by Kazunori Mizushima CLA
Modified: 2008-05-12 13:03 EDT (History)
3 users (show)

See Also:


Attachments
Simple patch fixing templates typo error (1.11 KB, patch)
2008-05-09 14:15 EDT, Martin Karpisek CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kazunori Mizushima CLA 2007-08-07 04:23:04 EDT
Build ID: I20070621-1340

Steps To Reproduce:
Given build.xml
<?xml version="1.0" encoding="UTF-8"?>
<project name="HW.makejar" default="makejar" basedir=".">
  |
</project>

1. edit the build.xml with ant editor
2. apply public target ant template at "|"

The result will be:
<?xml version="1.0" encoding="UTF-8"?>
<project name="HW.makejar" default="makejar" basedir=".">
<!-- ================================= 
          target: name              
         ================================= -->
    <target name="name" depends="depends" description="--> description">
        
    </target>
</project>

It should be:

<?xml version="1.0" encoding="UTF-8"?>
<project name="HW.makejar" default="makejar" basedir=".">
<!-- ================================= 
          target: name              
         ================================= -->
    <target name="name" depends="depends" description="description">
        
    </target>
</project>


More information:
The same bug is in buildFile1.
Comment 1 Martin Karpisek CLA 2008-05-09 14:15:56 EDT
Created attachment 99529 [details]
Simple patch fixing templates typo error

Patch removes "-->" from description attributes which is I think only typo error and not some clever trick
Comment 2 Darin Swanson CLA 2008-05-09 14:29:36 EDT
Thanks Martin...I will take a look.
Comment 3 Darin Swanson CLA 2008-05-11 00:26:15 EDT
Changes to ant.xml.
Comment 4 Darin Swanson CLA 2008-05-11 00:26:41 EDT
Please verify Darin W.
Comment 5 Darin Wright CLA 2008-05-12 12:53:29 EDT
I still see the "-->" in the description in a brand new empty workspace. It also appears in the Ant Editor templates preferences preview. 
Comment 6 Darin Wright CLA 2008-05-12 12:54:02 EDT
Also appears if I build a new file from a project template.
Comment 7 Darin Wright CLA 2008-05-12 13:02:47 EDT
My fault. Fixed.
Comment 8 Darin Wright CLA 2008-05-12 13:03:09 EDT
Verified. (<Must accept incoming changes before they work>).