Bug 198880 - [DataBinding] ObservablesManager does not dispose model
Summary: [DataBinding] ObservablesManager does not dispose model
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3.1   Edit
Assignee: Boris Bokowski CLA
QA Contact:
URL:
Whiteboard:
Keywords: greatbug
Depends on:
Blocks:
 
Reported: 2007-08-04 19:17 EDT by Bob Smith CLA
Modified: 2007-09-06 12:57 EDT (History)
1 user (show)

See Also:

Attachments
Test case for ObservablesManager (9.96 KB, patch)
2007-08-04 19:17 EDT, Bob Smith CLA 		no flags Details | Diff
Patch to make ObservablesManager dispose call the model's dispose method (11.56 KB, patch)
2007-08-04 19:18 EDT, Bob Smith CLA 		no flags Details | Diff
Patch to make ObservablesManager dispose call the model's dispose method (1.63 KB, patch)
2007-08-04 19:20 EDT, Bob Smith CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bob Smith CLA 2007-08-04 19:17:04 EDT 
Created attachment 75390 [details]
Test case for ObservablesManager

Build ID: HEAD

Steps To Reproduce:
1. Run ObservablesManagerTest contained in attached patch.
2. Note that the test fails as the model observable's dispose method isn't called.

More information:
Comment 1 Bob Smith CLA 2007-08-04 19:18:04 EDT 
Created attachment 75391 [details]
Patch to make ObservablesManager dispose call the model's dispose method
Comment 2 Bob Smith CLA 2007-08-04 19:20:48 EDT 
Created attachment 75392 [details]
Patch to make ObservablesManager dispose call the model's dispose method

Patch included test case, removed it.
Comment 3 Boris Bokowski CLA 2007-08-06 09:45:06 EDT 
D'oh!
Comment 4 Boris Bokowski CLA 2007-08-06 09:48:21 EDT 
3.3.1 candidate
Comment 5 Brad Reynolds CLA 2007-08-14 21:34:04 EDT 
(In reply to comment #4)
> 3.3.1 candidate
> 

+1
Comment 6 Boris Bokowski CLA 2007-08-15 13:59:30 EDT 
Released to 3.3 maintenance stream >20070815.

Thanks for this exemplary bug report, with test case and a fix, ready to go!
Comment 7 Boris Bokowski CLA 2007-09-06 12:57:26 EDT 
Verified in M20070905-1045 and released to HEAD.