Bug 198650 - [regression] assertion failed when restarting RSE with expanded FTP connection but no password
Summary: [regression] assertion failed when restarting RSE with expanded FTP connectio...
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows XP
: P3 minor (vote)
Target Milestone: 2.0.1   Edit
Assignee: Martin Oberhuber CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on: 196662
Blocks:
  Show dependency tree
 
Reported: 2007-08-02 07:20 EDT by Martin Oberhuber CLA
Modified: 2007-08-09 09:40 EDT (History)
0 users

See Also:

Attachments
Patch to fix the assertion (1.56 KB, patch)
2007-08-09 09:23 EDT, Martin Oberhuber CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2007-08-02 07:20:29 EDT 
Launch RSE as debuggee with assertions enabled 
(JRE options -ea -eas in the Launch).

Create an FTP connection (supposedly any connection type would work too).
When logging in, do save the username but not the password.
Expand it 2 levels deep.
Quit & restart RSE (with "Restore System View" preference).

On restart, it tries to re-open the connection but before showing the password prompt there is an error dialog (Unknown Error... details: error). Error log shows this exception:

org.eclipse.swt.SWTException: Failed to execute runnable (java.lang.AssertionError)
at org.eclipse.swt.SWT.error(SWT.java:3563)
   [...]
Caused by: java.lang.AssertionError
at org.eclipse.rse.internal.ui.view.SystemView.refreshRemoteObject(SystemView.java:2981)
at org.eclipse.rse.internal.ui.view.SystemViewPart$RestoreStateRunnable.runInUIThread(SystemViewPart.java:1728)
at org.eclipse.ui.progress.UIJob$1.run(UIJob.java:94)
at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:123)
... 23 more

This is most probably a regression of the fix for bug #196662.
Comment 1 Martin Oberhuber CLA 2007-08-09 09:23:55 EDT 
Created attachment 75763 [details]
Patch to fix the assertion

Attached patch fixes the assertion, but it's unclear whether RSE can restore the previous systemView state (this might be a regression)
Comment 2 Martin Oberhuber CLA 2007-08-09 09:24:49 EDT 
Patch applied:
[198650] Fix assertion when restoring workbench state
    SystemView.java  1.148
Comment 3 Martin Oberhuber CLA 2007-08-09 09:40:34 EDT 
Marking fixed since the assertion is fixed.

Not properly restoring the RSE view is covered in bug #199424.