Bug 198310 - PDE NLS wizard could use a Preview page
Summary: PDE NLS wizard could use a Preview page
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.4 M1   Edit
Assignee: Adam Archer CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-07-30 14:52 EDT by Wassim Melhem CLA
Modified: 2007-08-07 15:44 EDT (History)
2 users (show)

See Also:
wassim.melhem: review+

Attachments
patch (25.11 KB, patch)
2007-07-31 17:29 EDT, Adam Archer CLA 		no flags Details | Diff
patch (27.00 KB, patch)
2007-08-01 02:04 EDT, Adam Archer CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wassim Melhem CLA 2007-07-30 14:52:29 EDT 
Continuing with our streak of coolness, the PDE Tools > Externalize Strings... wizard could also use a Preview page like the Organize Manifests wizard.
Comment 1 Adam Archer CLA 2007-07-31 17:29:01 EDT 
Created attachment 75079 [details]
patch

This patch adds a preview to the NLS wizard.

This wizard is affected by the issue in bug 173793 comment 11 similarly to the new organize manifests wizard. This problem is currently being tracked in bug 198318.

This wizard should also be improved similarly to the enhancement for the organize manifests wizard in bug 198309.
Comment 2 Wassim Melhem CLA 2007-07-31 20:47:43 EDT 
Adam, it looks fine; however, it has the same problem as the Organize Manifests wizard in that once you go to the Preview page, you can never go back to the previous page.  It's a take-it-or-leave-it state.  The user should be able to flip back and forth between pages.
Comment 3 Adam Archer CLA 2007-08-01 02:04:06 EDT 
Created attachment 75095 [details]
patch

Adds next and back buttons to both wizards.
Comment 4 Wassim Melhem CLA 2007-08-02 00:38:57 EDT 
It worked well, so I released the patch.

However, I do have one concern when it comes to previewing changes in plugin.xml.  The highlighted regions start with the '=' character and the right double-quote is cut off.  I would have expected the region between the double quotes, but not including the double quotes, to be the highlighted regions.

How are the highlight regions being computed?
Comment 5 Wassim Melhem CLA 2007-08-02 09:35:07 EDT 
I released the patch after a minor modification to remove the workaround for bug 198535.

Thanks Adam.