Bug 198309 - Preview is not granular enough
Summary: Preview is not granular enough
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M1   Edit
Assignee: Adam Archer CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-07-30 14:50 EDT by Wassim Melhem CLA
Modified: 2007-08-07 15:44 EDT (History)
2 users (show)

See Also:

Attachments
patch (38.16 KB, patch)
2007-08-02 11:36 EDT, Adam Archer CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wassim Melhem CLA 2007-07-30 14:50:32 EDT 
The new Preview page in the Organize Manifests wizard is cool, but it is not granular enough.  It stops at the file (manifest.mf/plugin.xml) level.

In contrast, a Java preview shows you every individual change inside a file as a separate node, allowing you to control at a very granular level what changes you want applied to your files.
Comment 1 Adam Archer CLA 2007-08-02 11:36:21 EDT 
Created attachment 75238 [details]
patch

Adds granularity to both the Organize Manifests wizard preview and the new NLS wizard preview.

The edit names are being generated by the model change listeners since this is the only place that there is enough information to make them readable and informative. Unfortunately this means that some UI strings are in the core plug-in. To prevent unnecessary overhead, the names are only generated if the listeners are instantiated with a new constructor that accepts a boolean to indicate that they should be.
Comment 2 Wassim Melhem CLA 2007-08-02 22:19:02 EDT 
Fantastic.  Some might say 'a perfect patch'.