Bug 198278 - [importexport] Exporting a file passes a null monitor to the upload service
Summary: [importexport] Exporting a file passes a null monitor to the upload service
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 2.0.1   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-07-30 12:10 EDT by Javier Montalvo Orús CLA
Modified: 2012-05-23 16:50 EDT (History)
0 users

See Also:

Attachments
Patch passing a NulProgressMonitor to the upload service (1.44 KB, patch)
2007-07-30 12:17 EDT, Javier Montalvo Orús CLA 		mober.at+eclipse: iplog-
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Javier Montalvo Orús CLA 2007-07-30 12:10:28 EDT 
It can cause a NPE if the service doesn't expect null monitors such as bug 198182.
In this case it would be more sensible passing a NullProgressMonitor rather than null.
Comment 1 Javier Montalvo Orús CLA 2007-07-30 12:17:21 EDT 
Created attachment 74944 [details]
Patch passing a NulProgressMonitor to the upload service

This patch solves the issue as it passes a NulProgressMonitor instead of null to the upload service. This is just a suggestion, but it works fine.
Comment 2 David McKnight CLA 2007-07-30 12:39:25 EDT 
I've committed the patch to cvs.  Thanks.
Comment 3 Martin Oberhuber CLA 2012-05-23 16:50:25 EDT 
Comment on attachment 74944 [details]
Patch passing a NulProgressMonitor to the upload service

iplog- since Javier was committer since Aug 2006 already:
http://dev.eclipse.org/mhonarc/lists/dsdp-tm-dev/msg00375.html