Community
Participate
Working Groups
DS (5/1/01 2:14:44 PM) StructuredViewer#setSelection(ISelection, boolean) comment claims to not do call updateSelection(ISelection) if the selection is the same as the current selection. Appears to not be true from reviewing the code and from the selection changed callbacks that are occurring. Comment out of date or implementation oversight? NE (5/2/01 11:14:35 PM) Some code is relying on this to update viewer selection and notify listeners when table selection is tweaked, by doing v.setSelection(v.getSelection()). Should find better way of doing this, and make this match the spec. Is this causing problems elsewhere? DS (5/3/2001 3:05:12 PM) We have overridden the method so that we are not doing spurious updating on "selection" of the same selection. A fix would just remove the need for our code. NE (5/3/01 4:16:10 PM) I'm curious as to the use case that was causing problems. Who sends setSelection often enough with the same selection to make it worth filtering out duplicates? NE (5/3/01 4:57:43 PM) DS replies: Rapidly stepping in the same stack frame. The thread is started and stopped and we ensure that the top stack frame is selected and revealed.
Making the javadoc clearer is the safest change.
There are no plans for the UI team to work on this defect until higher priority items are addressed.
The Javadoc no longer promises not to call updateSelection() if the selection is unchanged. This was "fixed" for 3.0.