Bug 197110 - TeneoSQLNameStrategy should not remove the first vowel when doing truncation
Summary: TeneoSQLNameStrategy should not remove the first vowel when doing truncation
Status: VERIFIED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: Teneo (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Martin Taal CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-07-19 06:34 EDT by Benjamin Cabé CLA
Modified: 2008-05-27 19:19 EDT (History)
0 users

See Also:


Attachments
Fix to always preserve the first char (whether it's a vowel or not) during truncation (2.29 KB, patch)
2007-07-20 06:26 EDT, Benjamin Cabé CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Cabé CLA 2007-07-19 06:34:49 EDT
The truncation strategy could lead to confusing columns names when the first vowel is removed
We could have, for example, in the same table :
user_creator_id       --> user_creator_id
user_lastmodifier_id  --> sr_lst_mdifir_id

If you think it's worth fixing it, I can make the patch...
However, I don't know what would be the best to do when a name starts with more than one vowel... :-/

Regards,
Benjamin.
Comment 1 Martin Taal CLA 2007-07-20 05:51:54 EDT
Hi Benjamin,
You mentioned that you would provide a fix for this. I have a request. If you have time can you post the fix today? Not to push ofcourse :-). I ask because after tomorrow the next release will be 2 weeks from now because of cvs reorganisation work. If you don't have time then I can take care of it (as it is really trivial as you say). 

thanks.

gr. Martin
Comment 2 Benjamin Cabé CLA 2007-07-20 06:26:02 EDT
Created attachment 74249 [details]
Fix to always preserve the first char (whether it's a vowel or not)  during truncation
Comment 3 Martin Taal CLA 2007-07-21 07:15:32 EDT
Thanks, this has been included in the latest build: 0.8.0 / I200707210543
Comment 4 Nick Boldt CLA 2008-01-28 16:57:05 EST
Move to verified as per bug 206558.