Bug 196878 - [Manifest][Editors] Make "Edit..." button on "Extensions" page disappear
Summary: [Manifest][Editors] Make "Edit..." button on "Extensions" page disappear
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M1   Edit
Assignee: Adam Archer CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-07-17 16:22 EDT by Mike Pawlowski CLA
Modified: 2007-07-30 13:36 EDT (History)
1 user (show)

See Also:
mike.pawlowski: review? (wassim.melhem)

Attachments
patch (1.57 KB, patch)
2007-07-25 12:12 EDT, Adam Archer CLA 		no flags Details | Diff
patch (2.16 KB, patch)
2007-07-30 11:45 EDT, Adam Archer CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Pawlowski CLA 2007-07-17 16:22:34 EDT 
I'd like to move the "Edit..." button on the "Extensions" page to be the last button beside the tree viewer (under "Down" button) and set its visibility to false when it is not applicable.  As far as I know no one in the Eclipse SDK makes use of it.

Subject to Wassim's veto.  Wassim, if you agree that this bug is valid, could you provide background information and any additional requirements?
Comment 1 Wassim Melhem CLA 2007-07-17 16:28:05 EDT 
It is confusing that it is always disabled in the sdk, however it has real users out there for eclipse-based products.

I wouldn't put it at the bottom.  I would keep it clustered with Add...

When invisible, it would make for a nice space in the big ladder of buttons.
Comment 2 Adam Archer CLA 2007-07-25 12:12:12 EDT 
Created attachment 74590 [details]
patch

Edit button is now invisible instead of disabled.

Also removed the existing space between the edit and up buttons to make the gap caused by the invisible button slightly smaller. This means the buttons will now be side by side when edit is visible.
Comment 3 Peter Friese CLA 2007-07-27 03:55:39 EDT 
When working on bug #194529, I also found the disabled button very confusing. What are the use cases for this button? When will it ever be enabled? Is there any hint in the online help that one can use this button?

Many questions...

Anyway, since it only seems to be relevant for a limited number of users, I'd welcome if the patch supplied by Adam would make it into the next milestone.
Comment 4 Wassim Melhem CLA 2007-07-27 10:12:22 EDT 
Adam, the Up/Down button enablement is screwed up with this patch.
Comment 5 Adam Archer CLA 2007-07-30 11:45:46 EDT 
Created attachment 74939 [details]
patch

This mistake made me sad.

All better.
Comment 6 Wassim Melhem CLA 2007-07-30 13:36:00 EDT 
Patch released.  Thanks Adam.