Community
Participate
Working Groups
Build ID: I20070608-1718 Steps To Reproduce: 1. Open the org.eclipse.pde.ui plug-in. 2. Go to the Extensions tab. 3. In the filter, type "perspectives" without quotes. 4. There should only be one result. Click on it. Bug: Down button is enabled. The Up/Down buttons should be disabled when the filter is used, since users would have no idea what they are moving the selected elements relative to. Please assign the bug to me, since I need to take care of the same issue in the TOC editor.
I'd like to take care of this bug on the upcoming bugday.
Created attachment 74333 [details] Patch disables up/down buttons if the tree is filtered.
Great. Assigning to Peter.
Thanks for taking care of this one, Peter. :) The patch looks pretty good to me, but I would add a check, in FormFilteredTree#isFiltered(), to check if the filter text is equal to getInitialText(). Otherwise, the buttons are disabled when the filter contains the default value, "type filter text" (that text deactivates the filter).
(In reply to comment #4) > Thanks for taking care of this one, Peter. :) > > The patch looks pretty good to me, but I would add a check, in > FormFilteredTree#isFiltered(), to check if the filter text is equal to > getInitialText(). Otherwise, the buttons are disabled when the filter contains > the default value, "type filter text" (that text deactivates the filter). Thanks for the heads-up - I completely overlooked this one. I will adjust the patch accordingly. There is one more thing I'd like to discuss: I added an isFiltered() method to the FormFilteredTree class. While this surely works fine, it might be better to push this method up the inheritance tree a bit further. However, FilteredTree is not homed in PDE-land, but in org.eclipse.ui.dialogs. What's the preferred proceeding for situations like these?
Created attachment 74377 [details] Updated patch, fixes bug 194529 and 194828
Mike to review.
Comment on attachment 74377 [details] Updated patch, fixes bug 194529 and 194828 Tested very well. Thanks Peter.
Patch released to HEAD. Target: 3.4 M1 >> I added an isFiltered() method to the FormFilteredTree class. >> While this surely works fine, it might be better to >> push this method up the inheritance tree a bit further. >> However, FilteredTree is not homed in PDE-land, but in >> org.eclipse.ui.dialogs. What's the preferred proceeding for >> situations like these? The best way to proceed is to open a bug against the Platform/UI team (owner of org.eclipse.ui.dialogs). Outline the problem you cited above and reference this bug report. We can then revisit the PDE code to implement the new API. Thanks again.
