Bug 195295 - [website] fix layout of download page on IE6
Summary: [website] fix layout of download page on IE6
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P4 minor (vote)
Target Milestone: ---   Edit
Assignee: anatoly techtonik CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2007-07-03 13:30 EDT by Steffen Pingel CLA
Modified: 2008-12-09 22:22 EST (History)
1 user (show)

See Also:


Attachments
Screenshot on IE6 (77.30 KB, image/png)
2007-07-03 13:31 EDT, Steffen Pingel CLA
no flags Details
mylyn/context/zip (15.33 KB, application/octet-stream)
2007-07-06 20:25 EDT, Mik Kersten CLA
no flags Details
current look in ie6 (29.07 KB, image/gif)
2007-08-27 11:06 EDT, Eugene Kuleshov CLA
no flags Details
Patch against http://dev.eclipse.org/viewcvs/index.cgi/www/mylyn/downloads/index.php?revision=1.98&root=Eclipse_Website&view=markup (2.58 KB, patch)
2007-08-28 10:27 EDT, anatoly techtonik CLA
no flags Details | Diff
against revision=1.98 : avoid jumping download tables (4.97 KB, patch)
2007-08-29 08:16 EDT, anatoly techtonik CLA
no flags Details | Diff
tips page (60.22 KB, image/png)
2007-11-27 17:11 EST, Eugene Kuleshov CLA
no flags Details
download page (91.08 KB, image/png)
2007-11-27 20:57 EST, Eugene Kuleshov CLA
no flags Details
ie version (26.13 KB, image/jpeg)
2007-11-27 21:38 EST, Eugene Kuleshov CLA
no flags Details
liquid layout for downloads page (4.20 KB, patch)
2007-11-28 15:00 EST, anatoly techtonik CLA
no flags Details | Diff
Patched revision 1.153.. (6.44 KB, application/octet-stream)
2007-12-21 12:13 EST, anatoly techtonik CLA
no flags Details
merged patch (2.48 KB, patch)
2008-01-15 21:44 EST, Eugene Kuleshov CLA
no flags Details | Diff
problem is still there (91.04 KB, image/png)
2008-01-16 13:07 EST, Eugene Kuleshov CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2007-07-03 13:30:07 EDT
http://www.eclipse.org/mylyn/downloads/ :

On Konqueror and FireFox the Bugs and Archives icons are rendered to the right of the page body and not on the bottom.

On ie6 the whole page body is rendered below the menu.
Comment 1 Steffen Pingel CLA 2007-07-03 13:31:43 EDT
Created attachment 72975 [details]
Screenshot on IE6
Comment 2 Leo Dos Santos CLA 2007-07-03 15:01:07 EDT
(In reply to comment #0)
> http://www.eclipse.org/mylyn/downloads/ :
> 
> On Konqueror and FireFox the Bugs and Archives icons are rendered to the right
> of the page body and not on the bottom.

This is true of Safari as well.

Comment 3 Mik Kersten CLA 2007-07-06 20:25:54 EDT
Should be fixed now.  Looks like it weird rendering bug in the Browser.  Verified with Safari.

Steffen: could you verify with Konqueror?
Comment 4 Mik Kersten CLA 2007-07-06 20:25:56 EDT
Created attachment 73231 [details]
mylyn/context/zip
Comment 5 Steffen Pingel CLA 2007-07-06 20:50:07 EDT
Looks good now with konqueror and FireFox.
Comment 6 Steffen Pingel CLA 2007-07-07 01:35:41 EDT
IE6 still does not render the download page correctly (all other pages look okay though).
Comment 7 Mik Kersten CLA 2007-07-09 23:11:59 EDT
IE7 renders fine for me.  Could you attach an IE6 screenshot?
Comment 8 Eugene Kuleshov CLA 2007-07-09 23:21:08 EDT
I see that in IE body content goes down below left side bar if page is not wide enough. Same issue with Eclipse's wikipedia.
Comment 9 Steffen Pingel CLA 2007-07-09 23:42:58 EDT
 (In reply to comment #7)
> IE7 renders fine for me.  Could you attach an IE6 screenshot?

See attachments on this report :).
Comment 10 Mik Kersten CLA 2007-07-10 12:07:18 EDT
Duh, thanks.  That rendering problem makes even less sense than the prevoius ones ;)  What OS is this IE6 running on?
Comment 11 Steffen Pingel CLA 2007-07-10 12:19:07 EDT
Linux :). It's ies4linux but the rendering should be the same as on other OSs.
Comment 12 Steffen Pingel CLA 2007-07-10 12:20:21 EDT
Just noticed that the body content moves up when I make the window wide enough.
Comment 13 Shawn Minto CLA 2007-07-10 15:03:16 EDT
There are some online rendering tools that you can check to see what you page looks like without having all browsers installed.  One is http://ipinfo.info/netrenderer/index.php
Comment 14 Mik Kersten CLA 2007-07-13 02:20:46 EDT
Need to investigate IE6 rendering bug.
Comment 15 anatoly techtonik CLA 2007-08-20 09:20:25 EDT
The problem is in <div id="midcolumn" style="width:93%"> - it makes midcolumn width fixed in IE6. Would be nice to know how to fix this.
Comment 16 Mik Kersten CLA 2007-08-26 21:27:46 EDT
Anatoly: thanks for the pointer, that width specification did turn out to be the source of the problem.  Rather than taking it out, which would have made the page more narrow, I was able to work around it by adding a style="width:93%" attribute to the other div's on that page.
Comment 17 Eugene Kuleshov CLA 2007-08-27 11:06:17 EDT
Created attachment 77035 [details]
current look in ie6

Mik, did you pus this fix to the web site? I don't really see any improvements.
Comment 18 Mik Kersten CLA 2007-08-27 14:37:51 EDT
Yes, fix was pushed to the site along with the bug being marked resolved.  Since I don't have access to a machine with IE6 I verified the fix via: http://ipinfo.info/netrenderer/index.php  

Previous behavior was that non contents would show on the download page.  Current behavior is that contents show as with IE7.  Please comment if that's not the case. 
Comment 19 Eugene Kuleshov CLA 2007-08-27 15:51:07 EDT
See screenshot I've attached with my last comment. It doesn't seem like netrenderer allow to specify browser width, but you can reproduce it using http://www.browsercam.com/ With screen size set to 800x600 it seem look ok with IE7, but not in IE6 and IE55. In those browsers page body appear below left navigation bar when browser is narrow and this issue affects not only download page.
Comment 20 Mik Kersten CLA 2007-08-27 20:37:46 EDT
Argh, that's annoying.  Does this happen with other Mylyn pages (e.g. homepage) or just the download page?
Comment 21 Eugene Kuleshov CLA 2007-08-27 20:53:47 EDT
(In reply to comment #19)
> ...affects not only download page.

yes, it does affect homepage, but browser need to be narrower for that one.
Comment 22 anatoly techtonik CLA 2007-08-28 10:27:28 EDT
Created attachment 77134 [details]
Patch against http://dev.eclipse.org/viewcvs/index.cgi/www/mylyn/downloads/index.php?revision=1.98&root=Eclipse_Website&view=markup

IE6 is a pain (and CSS is a pain also). Nevertheless this patch should fix the problem.
Comment 23 Mik Kersten CLA 2007-08-28 15:11:51 EDT
Patch applied, thanks Antoly, that was very helpful and we should probably stick to using divs in this way.  All looks good on my end, but others should verify.  I did some additional tweaks of the spacing and layout.
Comment 24 Eugene Kuleshov CLA 2007-08-28 16:05:47 EDT
Hmm. The page header on download page is at the top now, but download table is still jumping below the left navigation bar.
Comment 25 anatoly techtonik CLA 2007-08-29 08:16:13 EDT
Created attachment 77239 [details]
against revision=1.98 : avoid jumping download tables

This patch fixes jumping tables by putting them in a wrapper div with clear:right property and setting float attribute for tables to none. 

Some &nbsp; removed to wrap the tables more compactly.

At less than 600px window width right side of the tables looks buggy in IE, but I can't think of any easy workarounds. In any case download links aren't pushed out of sight for that little audience of Mylyn users, who prefers IE6 over FF and works on less than 800x600 screen resolution.
Comment 26 anatoly techtonik CLA 2007-08-31 09:39:08 EDT
Reopened to keep track.
Comment 27 Mik Kersten CLA 2007-10-11 16:39:57 EDT
Antoly: are you still looking into this?  It looks like I didn't apply your latest patch, should it still be applied?
Comment 28 anatoly techtonik CLA 2007-10-13 09:55:02 EDT
Yep. The patch brings to a minimum look inconsistency between FF, IE and Opera.
Comment 29 Mik Kersten CLA 2007-11-27 16:50:07 EST
Antoly: the patch is not in a format that I can apply.  Could you check if you still see the failure (soime of these fixes have been applied), and if so try again and create a Unified/Workspace patch (these should be the default options)?
Comment 30 Eugene Kuleshov CLA 2007-11-27 17:11:54 EST
Created attachment 83907 [details]
tips page

Why this issue been closed? UI layout in IE is still broken
Comment 31 Mik Kersten CLA 2007-11-27 20:37:41 EST
Eugene: This bug is about the download page.  If you have a problem with the rendering of the download page please post a screenshot.  The rendering of the Tips page is in my list of web site updates, but feel free to file a new bug.
Comment 32 Eugene Kuleshov CLA 2007-11-27 20:57:25 EST
Created attachment 83917 [details]
download page

here you are
Comment 33 Mik Kersten CLA 2007-11-27 21:18:01 EST
What's the precise MSIE version that you are using?  I can not reproduce this with the latest (7.0.6000).
Comment 34 Eugene Kuleshov CLA 2007-11-27 21:38:51 EST
Created attachment 83922 [details]
ie version
Comment 35 anatoly techtonik CLA 2007-11-28 15:00:38 EST
Created attachment 84011 [details]
liquid layout for downloads page

http://dev.eclipse.org/viewcvs/index.cgi/www/mylyn/downloads/index.php?root=Eclipse_Website&view=log

My mistake to create the patch for rendered HTML page. This is the correct one for PHP code.
Comment 36 Mik Kersten CLA 2007-12-17 23:53:44 EST
Antoly: I still cannot apply your patch.  Could you provide me instructions with how to apply, or follow the convention that we use for creating workspace patches?  

  http://wiki.eclipse.org/index.php/Mylyn_Contributor_Reference#Patches
Comment 37 anatoly techtonik CLA 2007-12-21 12:13:11 EST
Created attachment 85726 [details]
Patched revision 1.153..

I do not know where is the problem. Seems ok for me. I attach patched version.

C:\>patch --verbose index.php patch.txt
Hmm...  Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|--- E:/Mylyn/1.153/index.php.orig      Wed Nov 28 21:45:38 2007
|+++ E:/Mylyn/1.153/index.php   Wed Nov 28 21:54:02 2007
--------------------------
Patching file index.php using Plan A...
Hunk #1 succeeded at 45.
Hunk #2 succeeded at 55.
Hunk #3 succeeded at 103.
Hunk #4 succeeded at 134.
done
Comment 38 Mik Kersten CLA 2008-01-15 19:57:28 EST
Anatoly: what are you creating the patch with?  I cannot apply it via Eclipse and always get conflicts.  It is not created in the right format because it refers to your "E:" drive (i.e. first line is --- E:/Mylyn/1.153/index.php.orig	Wed Nov 28 21:45:38 2007) which is confusing Eclipse's patch wizard.  Sorry for all the back-and-forth, but if if you are still interested in contributing this, please do the following:
* Synch up to the latest download page's index.php
* Create as per our instructions for creating Eclipse workspace patches http://wiki.eclipse.org/index.php/Mylyn_Contributor_Reference#Patches   Alternatively you could try to create a relative patch patch and Eclipse might let me apply that.

Eugene: I cannot reproduce the rendering problem with IE6 using http://ipinfo.info/netrenderer/index.php   If you can still reproduce it let me know, and it would be good if you could find a web-based renderer that showed the probem.
Comment 39 Eugene Kuleshov CLA 2008-01-15 21:44:47 EST
Created attachment 86998 [details]
merged patch

I've been able to apply patch and merge it to the HEAD. Here is the merged version
Comment 40 anatoly techtonik CLA 2008-01-16 03:02:00 EST
Thanks. I've made the patch with Winmerge, because I did not have sufficient bandwidth to checkout whole Mylyn tree to provide task context. It would helped me more if there was a link to an exemplary patch with some comments on the "Contributors reference" page.

Steffen: To see the bug you need to be able to contract the browser area. Netrenderer doesn't allow this.
Comment 41 Eugene Kuleshov CLA 2008-01-16 13:07:34 EST
Created attachment 87067 [details]
problem is still there

Mik, I don't know about web based rendereds, but problem is still there. You need to make your browser window narrow. If that windows is not tall enough, the download table is out of the screen and page looks blank.

BTW, the same issue appear with Eclipse's wiki skin. When window is narrow, the article text goes below the left navigation bar.
Comment 42 Steffen Pingel CLA 2008-12-09 22:22:10 EST
The page appears to render okay now on IE6.