Bug 194911 - [Help] Uncaught exceptions - Permission denied to get property Window.xxx
Summary: [Help] Uncaught exceptions - Permission denied to get property Window.xxx
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3.1   Edit
Assignee: Adam Archer CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-06-29 08:50 EDT by Pierre Candela CLA
Modified: 2007-07-03 18:05 EDT (History)
1 user (show)

See Also:


Attachments
avoid using the top property (1.69 KB, patch)
2007-06-29 08:52 EDT, Pierre Candela CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre Candela CLA 2007-06-29 08:50:02 EDT
Hi,
I'm trying to launch the standalone help from an RSA-signed applet.
My entry point is an html document on my file system: it contains a 2-frame frameset.
One of the frames references an html document embedding my applet.
Once the standalone help has started, the location of the other frame is changed to http://<port>:<portnumber>/help/index.jsp

Almost all features of the standalone help work fine. However, I have found 2 problems when:
1) I click on "Search scope"
-> in Firefox 2.0.0.4, I get the following message in the Error Console:
Error: uncaught exception: Permission denied to get property Window.screenX

2) I click "Print selected topic and all subtopics"
-> in Firefox 2.0.0.4, I get the following message in the Error Console:
Error: uncaught exception: Permission denied to get property Window.screenLeft

I was able to avoid these 2 problems with the following patch (see attachment).
Would you be willing to review it? And, if you're satisfied with it, apply it to HEAD and the 3.3 maintenance branch?

Thanks.
Comment 1 Pierre Candela CLA 2007-06-29 08:52:09 EDT
Created attachment 72773 [details]
avoid using the top property
Comment 2 Pierre Candela CLA 2007-06-29 08:53:15 EDT
(In reply to comment #0)
> http://<port>:<portnumber>/help/index.jsp

Oops. I meant to say http://<host>:<port>/help/index.jsp
Comment 3 Chris Goldthorpe CLA 2007-06-29 13:21:54 EDT
Adam, can you look review this patch?
Comment 4 Adam Archer CLA 2007-07-03 17:25:26 EDT
The patch relies on the deeply nested structure of frames in the help system which is not ideal, but most of the help system relies on this structure. Any future change to the framing would already require a massive overhaul, so one more instance of "parent.parent..." is not the end of the world.

Other than that, the patch is good.
Comment 5 Chris Goldthorpe CLA 2007-07-03 17:44:56 EDT
We should get this into 3.3.1. Both these situations were in code which was new in Eclipse 3.3.
Comment 6 Chris Goldthorpe CLA 2007-07-03 17:57:02 EDT
Fixed in HEAD
Comment 7 Chris Goldthorpe CLA 2007-07-03 18:05:10 EDT
Fixed in 3.3.1 maintenance stream.