Bug 194876 - Plugin sub-classes should call savePluginPreferences in stop implementation
Summary: Plugin sub-classes should call savePluginPreferences in stop implementation
Status: ASSIGNED
Alias: None
Product: DLTK
Classification: Technology
Component: Common (show other bugs)
Version: 0.95   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Dmitriy Kovalev CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2007-06-28 22:02 EDT by Jae Gangemi CLA
Modified: 2008-05-26 03:06 EDT (History)
1 user (show)

See Also:

Attachments
implemenation patch (7.62 KB, patch)
2007-06-28 22:03 EDT, Jae Gangemi CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jae Gangemi CLA 2007-06-28 22:02:12 EDT 
direct sub-classes of the Plugin class should call savePluginPreferences() in the stop method. 

sub-classes of the AbstractUI class do not need to worry about this step b/c AbstractUI.stop already makes a call to savePluginPreferences().

why Plugin doesn't do this automatically, when AbstractUI does escapes me. 

this also explains why some sub-classes of AbstractConfigurationBlockPreferencePage need to make a call to their underlying preference store as well. (see bug 194217).

it should also be noted that this will become useful for mac users when bug 194146 is fixed.
Comment 1 Jae Gangemi CLA 2007-06-28 22:03:27 EDT 
Created attachment 72754 [details]
implemenation patch

adds savePluginPreferences to all the stop() methods, will act as save 'failsafe' as well.
Comment 2 Eclipse Webmaster CLA 2007-07-29 09:23:16 EDT 
Changing OS from Mac OS to Mac OS X as per bug 185991
Comment 3 Andrey Platov CLA 2008-05-26 03:06:23 EDT 
bulk version set: 0.95