Community
Participate
Working Groups
the soon-to-be-attached patch contains refactoring work that refactors the ruby debugger preference page to use the AbstractConfigurationBlock and AbstractConfigurationBlockPreferencePage framework classes, in addition to providing bases classes that other dltk languages can use to achieve the 'drop down' engine selector. i've also added a 'link' that will enable navigation to the generic dltk debugging options as well. the 'SWTFactory' class is a cut and paste out of the jdt (i wish this was part of eclipse core) - if you don't wish to use it, you'd need to replace the guts of the calls in AbstractConfigurationBlock w/ the proper impls since it just delegates to keep the model consistent. i was going to hold off on submitting this until i had finished up integrating w/ active state's ruby debug (and the perl impl i'm working on) - but i noticed changes to the classes this morning, and figured it best just to get this submitted.
marking as dependency of bug 193638 b/c the plugin.xml in the diff references the pulled up ScriptSourceLookupDirector
Created attachment 72361 [details] patch w/ refactorings
Thank you for patch, I've applied it with several modifications.
cool - one thing i noticed is that RubyDebugPreferencePage implements performOk, which makes a call to save the plugin preferences. i thought was handled automatically by the OverlayPreferenceStore that wraps the plugin preferences (at least it seemed to work that way when i tested it). is that not really the case?
As I understand correctly, it's required. You can see the implementation of performOk in AbstractConfigurationBlockPreferencePage class. By default it saves preferences to DLTKUIPlugin but the debugger preferences should be saved to another plugin. Perhaps more refactoring is required on configuration blocks infrastructure.
Changing OS from Mac OS to Mac OS X as per bug 185991
bulk change: fixed in 0.95
