Bug 194694 - 'External Plugin Libraries' should be filtered
Summary: 'External Plugin Libraries' should be filtered
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M1   Edit
Assignee: Peter Friese CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, contributed
Depends on:
Blocks:
 
Reported: 2007-06-27 18:17 EDT by Chris Aniszczyk CLA
Modified: 2008-02-26 21:50 EST (History)
5 users (show)

See Also:
caniszczyk: review+


Attachments
Patch to fix 194694 (4.36 KB, patch)
2007-07-25 14:58 EDT, Peter Friese CLA
no flags Details | Diff
mylyn/context/zip (1.55 KB, application/octet-stream)
2007-07-25 14:59 EDT, Peter Friese CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Aniszczyk CLA 2007-06-27 18:17:03 EDT
If you add things to Java Search, an ugly and visible project is created in your workspace called 'External Plug-in Libraries'

This should be hidden by default as new users might be confused where this comes from and may delete it or do something silly.
Comment 1 Wassim Melhem CLA 2007-07-15 02:07:27 EDT
DJ and Kevin are big fans of this function.  We should get their input on whether this project should be hidden (e.g. have a name that starts with '.' etc.)

I suspect DJ likes to see it since he likes the entries to be sorted (bug 177773).
Comment 2 DJ Houghton CLA 2007-07-19 15:23:41 EDT
Since I was forced to see it, I wanted the entries sorted. But if there was a filter or something so it could be hidden, that would be fine with me.
Comment 3 Wassim Melhem CLA 2007-07-19 15:51:12 EDT
Assigning to Adam.

I think we need a new separate filter here (ie. we don't want to reuse existing ones like the binary projects filter).

The filter is on by default, and since the project that gets created has a hardcoded name, it should just filter out the project by its name.
Comment 4 Peter Friese CLA 2007-07-25 14:58:51 EDT
Created attachment 74608 [details]
Patch to fix 194694
Comment 5 Peter Friese CLA 2007-07-25 14:59:04 EDT
Created attachment 74609 [details]
mylyn/context/zip
Comment 6 Chris Aniszczyk CLA 2007-07-25 15:04:24 EDT
I'll review later today and release.

This brings me so much joy because I've always hated seeing that mystery project ;p
Comment 7 Chris Aniszczyk CLA 2007-07-26 00:33:29 EDT
committed to HEAD.

This filter is now on by default. 

Blogged about it in your honor :)
	http://mea-bloga.blogspot.com/2007/07/pde-and-bugday.html
Comment 8 Chris Aniszczyk CLA 2007-07-26 00:38:01 EDT
btw Peter, I enabled this filter by default, which was a very small change in the plugin.xml for the filters (basically a yes instead of a no). I also attributed the work to you via the copyright.

Thanks!
Comment 9 Wassim Melhem CLA 2007-07-26 00:47:45 EDT
Chris, stop wiping out the target milestone ;)
Comment 10 Chris Aniszczyk CLA 2007-07-26 00:49:02 EDT
blame Mik, it's a Mylyn bug.
Comment 11 Peter Friese CLA 2007-07-26 02:33:01 EDT
(In reply to comment #7)
> Blogged about it in your honor :)
>         http://mea-bloga.blogspot.com/2007/07/pde-and-bugday.html
Thanks a lot!


(In reply to comment #8)
> btw Peter, I enabled this filter by default, which was a very small change in
> the plugin.xml for the filters (basically a yes instead of a no). 
Shame on me for forgetting this one. One should not do "copy-paste"... Well, good you reviewed and fixed it :-)
Comment 12 Kevin McGuire CLA 2007-08-02 11:46:28 EDT
I'm a bit late to the party but I'll add my 2c worth.

I've always found the presentation of the Java search elements as a pseudo project to be rather odd.  I understand the technical constraints that got us there though.  It does solve the problem of having a place for these elements to show up in the package explorer.  A more involved solution would be one where say there was a separate explorer tab for the libraries (although that introduces other issues around navigation), or some kind of split area in the explorer, or something more clever we've not thought of.

With the present restrictions and in the absence of a major rethink, the current solution is odd but workable. Adding filtering is at least a consistent step but in my mind a workaround for a more subtle problem.
Comment 13 David Kyle CLA 2008-02-26 11:55:50 EST
The problem with hidding "External Plug-in Libraries" by default in 3.4 is it breaks the FAQ "How do I find a particular class from an Eclipse plug-in?".

http://wiki.eclipse.org/FAQ_How_do_I_find_a_particular_class_from_an_Eclipse_plug-in%3F

It just moves the Eclipse IDE farther and farther away from the original books. Are new editions in works?
Comment 14 Chris Aniszczyk CLA 2008-02-26 12:02:12 EST
Adding things to Java Search still works, along with Ctrl+Shift+T. You just don't see the hack of a project where the class comes from :)

As a side note, Jeff, Jean and I are working on updating the RCP Book for 3.4
Comment 15 David Kyle CLA 2008-02-26 12:26:07 EST
(In reply to comment #14)
> As a side note, Jeff, Jean and I are working on updating the RCP Book for 3.4
Woot!!! :-)
Comment 16 Willian Mitsuda CLA 2008-02-26 18:59:55 EST
 (In reply to comment #14)
> As a side note, Jeff, Jean and I are working on updating the RCP Book for 3.4

Fantastic! Is there a scheduled date?

The only drawback of Eclipse books is that they look a little outdated as soon as they get published :(
Comment 17 Chris Aniszczyk CLA 2008-02-26 21:50:59 EST
> Fantastic! Is there a scheduled date?

There's no scheduled date as we can't guarantee anything yet, but we're shooting to have something done a few months after EclipseCon, if not sooner. A lot has changed since 3.1 guys :P