Bug 19459 - [ExternalTools] failure to execute invalid tools should be better handled by ui.
Summary: [ExternalTools] failure to execute invalid tools should be better handled by ui.
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Ant (show other bugs)
Version: 2.1   Edit
Hardware: PC All
: P3 enhancement (vote)
Target Milestone: 2.1 RC1   Edit
Assignee: Darin Wright CLA
QA Contact:
URL:
Whiteboard:
Keywords: ui
Depends on:
Blocks:
 
Reported: 2002-06-06 00:57 EDT by Chris McLaren CLA
Modified: 2003-02-19 20:14 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris McLaren CLA 2002-06-06 00:57:33 EDT
clean f2:
create a tool with an invalid location. execute.

two dialogs appear: first, a progress information dialog saying 'operation in 
progress' but not yet rendering a progress bar, and an error dialog 'problem 
running external tool'. 

1. the progress information dialog should not appear. is it not possible to 
attempt to start the tool's process before starting the progress information 
dialog?

2. the error message "the tool's file does not exist for the external tool 
named <name>" should be better worded and more descriptive. Perhaps 
replace "tool's file" with "tool" somehow. Consider "Tool <name> could not be 
run/executed/found.\n\nLocation: <location>\nArguments: <arguments>" (etc..). 

i personally prefer that the title of error message boxes are always "Error" 
and the message text reveals the nature of the error, but whatever the naming 
scheme it should be consistent across Eclipse.
Comment 1 Simon Arsenault CLA 2002-06-06 15:04:00 EDT
Defer until after release 2.0  This happens in other areas of Eclipse also. 
Maybe a generic solution can be found?
Comment 2 Darin Swanson CLA 2002-10-03 16:52:56 EDT
Remove the Later resolution
Comment 3 Darin Swanson CLA 2002-10-03 16:53:41 EDT
Trying again
Comment 4 Darin Wright CLA 2002-11-15 11:02:14 EST
Using the launch config support, I cannot create a tool with an invalid 
location (the launch dialog verifies the location, and will not let me save it).

If I configure a tool to run an ant script, and then change the name of the ant 
scrpit, I get the following error message in a dialog:

"The variable workspace_loc with argument /A/hello.xml could not be expanded to 
a valid path". 

We could improve this error message. 
Comment 5 Darin Swanson CLA 2003-02-06 10:49:16 EST
Revisit after 2.1
Comment 6 Jared Burns CLA 2003-02-19 16:00:25 EST
Feedback from users indicates that the error message is extremely confusing.
We should make the message more helpful.
Comment 7 Jared Burns CLA 2003-02-19 18:23:42 EST
Fixed. When a variable cannot be expanded, the variable expander now throws
a CoreException with a status containing a meaningful message.

Please verify, DarinW.
Comment 8 Darin Wright CLA 2003-02-19 20:14:34 EST
Verified