Bug 194360 - add action to task editor to compare attachments
Summary: add action to task editor to compare attachments
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC All
: P3 enhancement (vote)
Target Milestone: 2.3   Edit
Assignee: Eugene Kuleshov CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, helpwanted
: 155294 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-06-25 23:46 EDT by Eugene Kuleshov CLA
Modified: 2008-11-04 21:30 EST (History)
1 user (show)

See Also:

Attachments
contributed compare attachments action (14.50 KB, text/plain)
2007-12-12 13:44 EST, Eugene Kuleshov CLA 		no flags Details
mylyn/context/zip (25.01 KB, application/octet-stream)
2007-12-12 13:44 EST, Eugene Kuleshov CLA 		no flags Details
mylyn/context/zip (30.89 KB, application/octet-stream)
2008-02-11 23:50 EST, Mik Kersten CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Kuleshov CLA 2007-06-25 23:46:12 EDT 
add action to task editor to compare attachments. it would be handy to see progress in attached patches (or pictures)
Comment 1 Eugene Kuleshov CLA 2007-12-12 13:44:53 EST 
Created attachment 85107 [details]
contributed compare attachments action

With those sequential patches on bugs like bug 181388 and bug 210686, I thought that comparison action could be useful to get a first glance what been changed between patch revisions.

I didn't want to change existing actions from popup menu in the attachment list, but some of them probably should be converted into the object contributions.
Comment 2 Eugene Kuleshov CLA 2007-12-12 13:44:56 EST 
Created attachment 85108 [details]
mylyn/context/zip
Comment 3 Eugene Kuleshov CLA 2008-01-23 00:17:58 EST 
*** Bug 155294 has been marked as a duplicate of this bug. ***
Comment 4 Mik Kersten CLA 2008-02-11 23:15:58 EST 
Eugene: why did you comment out the following from ..mylyn.team.ui/plugin.xml?

            <!--
            <enablement>
               <objectClass
                     name="org.eclipse.mylyn.tasks.core.RepositoryAttachment">
               </objectClass>
            </enablement>
            -->
Comment 5 Eugene Kuleshov CLA 2008-02-11 23:31:48 EST 
(In reply to comment #4)
> Eugene: why did you comment out the following from ..mylyn.team.ui/plugin.xml?

It seem redundant because same class is declared in the objectContribution element. Did I miss something?
Comment 6 Mik Kersten CLA 2008-02-11 23:50:48 EST 
No, that looks good, I hadn't noticed the redundancy and I deleted the XML you commented out.

Patch applied, good stuff.  The only changes I made were to add an image and to remove the "..." ellipses from the label since no user input or choice is required after the action runs.  I also removed the ellipses from the "Retrieve Context" action that's on the attachments table for the same reason.
Comment 7 Mik Kersten CLA 2008-02-11 23:50:51 EST 
Created attachment 89476 [details]
mylyn/context/zip