Bug 194185 - [search] for package declarations finds also subpackages
Summary: [search] for package declarations finds also subpackages
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.3.1   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 192638
  Show dependency tree
 
Reported: 2007-06-25 06:18 EDT by Markus Keller CLA
Modified: 2008-09-16 06:02 EDT (History)
2 users (show)

See Also:


Attachments
Proposed patch (5.97 KB, patch)
2007-06-26 07:05 EDT, Frederic Fusier CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2007-06-25 06:18:53 EDT
N20070625-0010, was OK in 3.2.2

- new runtime workspace
- paste everything below the long ------------- into Package Explorer
- in host workbench set a breakpoint on line 847 in org.eclipse.jdt.internal.corext.refactoring.rename.RenamePackageProcessor.PackageRenamer.getNamesakePackages(..)
- rename package org.eclipse.rwt to a (check Rename subpackages)

=> pattern was created with
SearchPattern.R_EXACT_MATCH | SearchPattern.R_CASE_SENSITIVE, but search finds wrong matches
- org.eclipse.rwt.internal
- org.eclipse.rwt.internal.fixme
- org.eclipse.rwt.widgets
in addition to the correct
- org.eclipse.rwt.widgets


------------------------------------------------------------------

package org.eclipse.rwt;
public class RWT {
	public static void error() { }
}

//---

package org.eclipse.rwt.internal.fixme;
public class AdapterManagerAccess {
	public static Object getAdapterManager() {
		return null;
	}
}

//---

package org.eclipse.rwt.widgets;

import org.eclipse.rwt.RWT;
import org.eclipse.rwt.internal.fixme.AdapterManagerAccess;

public abstract class Widget {

	protected void checkSubclass() {
		RWT.error();
	}

	public Object getAdapter(Class adapter) {
		return AdapterManagerAccess.getAdapterManager().hashCode();
	}
}
Comment 1 Frederic Fusier CLA 2007-06-26 07:05:50 EDT
Created attachment 72463 [details]
Proposed patch
Comment 2 Frederic Fusier CLA 2007-06-26 07:07:13 EDT
Released for 3.4M1 in HEAD stream.
Comment 3 Frederic Fusier CLA 2007-06-26 07:07:49 EDT
Jerome,
Is it ok to backport the fix for 3.3.1?
Comment 4 Jerome Lanneluc CLA 2007-06-26 07:10:38 EDT
+ 1 for backporting to 3.3.1
Comment 5 Frederic Fusier CLA 2007-06-28 12:51:45 EDT
Released for 3.3.1 in R3_3_maintenance stream.
Comment 6 Frederic Fusier CLA 2007-08-03 09:52:46 EDT
Verified for 3.4M1 using build I20070802-0800.
Comment 7 Frederic Fusier CLA 2007-08-03 10:14:15 EDT
Reopen for 3.3.1 verification
Comment 8 Frederic Fusier CLA 2007-08-03 10:14:59 EDT
Reopen for 3.3.1 verification
Comment 9 Frederic Fusier CLA 2007-08-07 06:16:03 EDT
.
Comment 10 David Audel CLA 2007-09-03 07:19:54 EDT
Verified for 3.3.1 using build M20070831-2000.