Bug 1936 - Problem when overriding Dialog.createDialogArea (1GCQBAP)
Summary: Problem when overriding Dialog.createDialogArea (1GCQBAP)
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 2.0   Edit
Hardware: All Windows NT
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Ian Petersen CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-10-10 22:22 EDT by Andre Weinand CLA
Modified: 2002-01-28 16:36 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andre Weinand CLA 2001-10-10 22:22:37 EDT 
If Dialog.createDialogArea(Composite parent) is overridden and a FComposite is returned nothing
	will be visible unless the correct layout data has been set on the Composite.

	This is problematic since it couples a client's implementation of createDialogArea to an implementation detail 
	of the base class (and it shows thatControl.setLayoutData is not a good idea in the first place).

	If this  behavior cannot be fixed it should be documented in the method's JavaDoc!

NOTES:
Comment 1 DJ Houghton CLA 2001-10-24 06:50:35 EDT 
PRODUCT VERSION:
	SDK 0.047
Comment 2 Kevin Haaland CLA 2002-01-21 21:43:37 EST 
My preference would be to update the javadoc.
Comment 3 Ian Petersen CLA 2002-01-28 16:36:44 EST 
The javadoc has been changed to reflect the dependency in both createDialogArea 
and createButtonBar.