Community
Participate
Working Groups
If I have a plug-in with the same version installed in both eclipse and an extension location, it is listed twice in the import dialog. Is is reasonable to request that plug-ins with the same version only be listed once instead? To reproduce: 1. Extract attachment (to follow) in the root of eclipse 2. Replace the plug-ins it contains with the same from your eclipse installation 3. Start eclipse with -clean or by deleting the folders in the configuration directory. 4. Execute "File -> Import -> Plug-ins and Fragments" and accept defaults until you are presented with the Plug-ins and Fragments Selection dialog 5. Notice that org.eclipse.core.filesystem and org.eclipse.core.jobs is listed twice.
Created attachment 71949 [details] extension location with links
What build are you using
I20070525-1350 (believe this is RC2).
We had a similar problem with duplicate plug-ins in the target plug-ins view (bug 184960). But it appears it should have been fixed in the I20070525-0010 build and after. I will look into this one when I get a chance. I don't think this should be too hard to fix.
This is definitely different than 184960. In 184960, we referenced the same plug-in in the same location twice. In this bug, we have identical plug-ins in two locations. The fix is to not add a BundleDescription to the resolver state if the state already contains a bundle with the same BSN and version. Modified org.eclipse.pde.internal.core.MinimalState.addBundle(Dictionary, File, long).
Brian, I am not sure I like this resolution. Two bundles at different locations are different bundles. PDE supports multiple bundles by the same symbolic name, regardless of version number. In the case of the import wizard, the wizard should not be too smart. It should show both. After all, the code inside can be different. Perhaps the label could show the location to distinguish. If the user does not want to see linked plug-ins, they can point to a single location on the first page of the import wizard, instead of choosing the default (which grabs links).
reversed Brian's patch since it broke a basic self-hosting scenario: 1. Create a new plug-in project (com.example.abc 1.0.0) 2. Create a new plug-in project. Name the project com.example.def, but the bundle ID/version should be set to com.example.abc and 1.0.0. Note how the second project does not resolve and does not compile.
Deferred. Still marked as bug day for anyone who wants to take a crack at it.
The import wizard should not do special processing to remove duplicates. If you import from a target platform that has multiple identical bundles, we should allow the user to import any of them. Closing as WONTFIX.
