Bug 184960 - Duplicate Fragment Entries in the Target Platform
Summary: Duplicate Fragment Entries in the Target Platform
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 critical (vote)
Target Milestone: 3.3 RC2   Edit
Assignee: Brian Bauman CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 185639 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-05-01 15:28 EDT by Chris Aniszczyk CLA
Modified: 2007-05-24 19:32 EDT (History)
3 users (show)

See Also:
wassim.melhem: review+
mike.pawlowski: review+

Attachments
patch (1.42 KB, patch)
2007-05-24 17:49 EDT, Brian Bauman CLA 		mike.pawlowski: review+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Aniszczyk CLA 2007-05-01 15:28:51 EDT 
When we added support for multiple versions of things it seems we may have broken something in respect to fragments. I suggest you start with the Eclipse NL pack to see if you can reproduce the issue, if not, we can arrange me sending you a large target platform full of Lotus goodness.
Comment 1 Wassim Melhem CLA 2007-05-05 01:19:43 EDT 
*** Bug 185639 has been marked as a duplicate of this bug. ***
Comment 2 Wassim Melhem CLA 2007-05-23 14:10:32 EDT 
Chris, can you take a look at this one too.  Just make sure we are ignoring duplicates when going through sites.
Comment 3 Brian Bauman CLA 2007-05-24 17:49:24 EDT 
Created attachment 68684 [details]
patch

simple two line patch.  Using HashSet instead of ArrayList to guard from duplicated link files or duplicated URL bundle locations.
Comment 4 Brian Bauman CLA 2007-05-24 17:51:40 EDT 
Mike and Wassim to review since Chris is on vacation.
Comment 5 Wassim Melhem CLA 2007-05-24 17:55:23 EDT 
Patch is good.  Thanks.
Comment 6 Brian Bauman CLA 2007-05-24 17:56:00 EDT 
Just for clarification, I heard through the PDE grapevine the duplicates were
coming from a link file that was pointing back to the original target platform. 

This was causing us to parse a site twice, and come up with duplicate URLs for
the same plug-in.  The fix is intended to ignore duplicate information.
Comment 7 Mike Pawlowski CLA 2007-05-24 19:31:58 EDT 
Comment on attachment 68684 [details]
patch

Nice clean patch, Brian.
Comment 8 Mike Pawlowski CLA 2007-05-24 19:32:24 EDT 
Patch released to HEAD.