Bug 193314 - [Dialogs] ResourceSelectionDialog shouldn't materialize entire tree
Summary: [Dialogs] ResourceSelectionDialog shouldn't materialize entire tree
Status: RESOLVED WORKSFORME
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Boris Bokowski CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: performance
Depends on:
Blocks:
 
Reported: 2007-06-19 09:40 EDT by Michael Valenta CLA
Modified: 2019-09-02 15:08 EDT (History)
4 users (show)

See Also:


Attachments
Trace from CTRL-BReak while seemingly frozen (1.38 MB, text/plain)
2007-06-19 09:41 EDT, Michael Valenta CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Valenta CLA 2007-06-19 09:40:58 EDT
I was experimenting with the latest EMF off the Europa update site. I right-clicked on my example model.ecore file and chose Map to Ecore... not knowing anything about what the command does. A dialog popped up containing a checkbox tree. I expanded and then checked the top level entry and not only was Eclipse hung but my laptop was brought to it's knees.

It may be of interest to know that I have most of the Eclipse SDK in my workspace as well as the SSE XML editor and the plug-ins it requires.
Comment 1 Michael Valenta CLA 2007-06-19 09:41:57 EDT
Created attachment 71733 [details]
Trace from CTRL-BReak while seemingly frozen
Comment 2 Marcelo Paternostro CLA 2007-06-19 13:36:54 EDT
This is a serious issue that should be addressed by the Eclipse UI team given that the problem is in the implementation of eclipse.ui.dialogs.ResourceSelectionDialog.  

In EMF we've solved the problem as described in this bugzilla https://bugs.eclipse.org/bugs/show_bug.cgi?id=193367 .
Comment 3 Susan McCourt CLA 2007-06-19 21:47:40 EDT
cc'ing Boris since this involves expansion of a tree viewer with many items.
Comment 4 Boris Bokowski CLA 2007-06-19 23:15:41 EDT
CheckboxTreeAndListGroup traverses (and materializes!) the whole tree. Not sure why we do this but it looks like it's a bad idea for big workspaces.
Comment 5 Marcelo Paternostro CLA 2007-06-22 11:06:34 EDT
If you guys decide to improve this dialog, perhaps you could also consider implementing this feature request that I've opened back in 2005:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=91227
Comment 6 Susan McCourt CLA 2007-06-27 16:55:36 EDT
I think Krzysztof owns bugs for this dialog now.
Comment 7 Chris Aniszczyk CLA 2007-08-01 18:20:17 EDT
Don't ask me how I found this bug, but I did.

Why doesn't the EMF team contribute the dialog back if their version is so much better? It seems like it should be a trivial contribution that benefits many.
Comment 8 Mike Wilson CLA 2008-04-10 15:32:26 EDT
Is anyone working on this?
Comment 9 Boris Bokowski CLA 2008-05-28 12:09:06 EDT
(In reply to comment #2)
> In EMF we've solved the problem as described in this bugzilla
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=193367 .

Downgrading since the original problem was solved on the EMF side. Or can this bug be reproduced using only the SDK?
Comment 10 Eclipse Genie CLA 2019-02-10 08:06:31 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 11 Lars Vogel CLA 2019-09-02 15:04:37 EDT
This bug has been marked as stalebug a while ago without any further interaction.

If this report is still relevant for the current release, please reopen and remove the stalebug whiteboard flag.
Comment 12 Lars Vogel CLA 2019-09-02 15:08:28 EDT
This bug was marked as stalebug a while ago. Marking as worksforme.

If this report is still relevant for the current release, please reopen and remove the stalebug whiteboard tag.